feat: Sponsorblock duration for skip messages#5669
Open
Rassi wants to merge 3 commits into
Open
Conversation
Owner
|
Thanks. I'll review the pr later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use skip confirmation for all sponsor block types, so I can control when I want to skip. But it depends on whether or not it is a segment I feel is "too long", so I would like to see duration of the segment to see if I want to skip.
This adds an option to show the segment duration (e.g. "0:06") in SponsorBlock skip and confirmation messages. The setting can be found in SponsorBlock settings > Misc > "Show duration in skip message" and is off by default.
Also shortens the skip message format ("Skip" instead of "Skip segment") to better fit longer category names with duration on one line.