Skip to content

Fix account picker showing two filled radio buttons #5820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CodeSculptor wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

Fix account picker showing two filled radio buttons #5820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...m/liskovsoft/smartyoutubetv2/common/app/presenters/dialogs/AccountSelectionPresenter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,13 @@ private void createAndShowDialog(List<Account> accounts, List<Drawable> icons, b
private void appendAccountSelection(List<Account> accounts, List<Drawable> icons, AppDialogPresenter settingsPresenter) {
List<OptionItem> optionItems = new ArrayList<>();

// "None" is selected only when no account is currently selected — otherwise the
// radio category renders two filled buttons (None + the active account).
optionItems.add(UiOptionItem.from(
getContext().getString(R.string.dialog_account_none), optionItem -> {
selectAccount(null);
settingsPresenter.closeDialog();
}, true
}, mSignInService.getSelectedAccount() == null
));

int index = -1;
Expand Down
4 changes: 3 additions & 1 deletion ...m/liskovsoft/smartyoutubetv2/common/app/presenters/settings/AccountSettingsPresenter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,13 @@ private void appendSelectAccountSection(List<Account> accounts, List<Drawable> i

List<OptionItem> optionItems = new ArrayList<>();

// "None" is selected only when no account is currently selected — otherwise the
// radio category renders two filled buttons (None + the active account).
optionItems.add(UiOptionItem.from(
getContext().getString(R.string.dialog_account_none), optionItem -> {
AccountSelectionPresenter.instance(getContext()).selectAccount(null);
settingsPresenter.closeDialog();
}, true
}, getSignInService().getSelectedAccount() == null
));

CharSequence accountName = " (" + getContext().getString(R.string.dialog_account_none) + ")";
Expand Down
⚡