fix: make Docker service label configurable for staging#203
Merged
zainfathoni merged 1 commit intomainfrom Jan 10, 2026
Merged
Conversation
The Kamal service label was hardcoded to 'kelas', causing staging deployment to fail. Now uses SERVICE_NAME build arg with 'kelas' as default, and staging workflow passes 'kelas-staging'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix staging deployment failure caused by hardcoded Docker service label.
Error:
Image is missing the 'service' labelThe Kamal service label was hardcoded to
kelasin the Dockerfile, but staging expectskelas-staging.Changes
SERVICE_NAMEbuild arg to Dockerfile (defaults tokelas)SERVICE_NAME=kelas-stagingTest plan