Skip to content

fix: make Docker service label configurable for staging#203

Merged
zainfathoni merged 1 commit intomainfrom
fix/staging-service-label
Jan 10, 2026
Merged

fix: make Docker service label configurable for staging#203
zainfathoni merged 1 commit intomainfrom
fix/staging-service-label

Conversation

@zainfathoni
Copy link
Copy Markdown
Owner

Summary

Fix staging deployment failure caused by hardcoded Docker service label.

Error: Image is missing the 'service' label

The Kamal service label was hardcoded to kelas in the Dockerfile, but staging expects kelas-staging.

Changes

  • Add SERVICE_NAME build arg to Dockerfile (defaults to kelas)
  • Update deploy-staging.yml to pass SERVICE_NAME=kelas-staging

Test plan

The Kamal service label was hardcoded to 'kelas', causing staging
deployment to fail. Now uses SERVICE_NAME build arg with 'kelas' as
default, and staging workflow passes 'kelas-staging'.
@zainfathoni zainfathoni enabled auto-merge January 10, 2026 14:46
@zainfathoni zainfathoni merged commit d77a96d into main Jan 10, 2026
8 checks passed
@zainfathoni zainfathoni deleted the fix/staging-service-label branch January 10, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant