fix(security): use maxAge instead of expires for session cookies#209
Merged
zainfathoni merged 1 commit intomainfrom Jan 23, 2026
Merged
fix(security): use maxAge instead of expires for session cookies#209zainfathoni merged 1 commit intomainfrom
zainfathoni merged 1 commit intomainfrom
Conversation
Session cookies were expiring immediately because the expires date was calculated at server startup time. After 7+ days of server uptime, all new cookies would have an expiration date in the past. Also adds error feedback display on login page when email verification fails (e.g., burner email, invalid format). Closes rb-login-broken Amp-Thread-ID: https://ampcode.com/threads/T-019bed38-9b38-74b0-8aa7-70eaf424dcc6 Co-authored-by: Amp <amp@ampcode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
zainfathoni
added a commit
that referenced
this pull request
Jan 25, 2026
Session cookies were expiring immediately because the expires date was calculated at server startup time. After 7+ days of server uptime, all new cookies would have an expiration date in the past. Also adds error feedback display on login page when email verification fails (e.g., burner email, invalid format). Closes rb-login-broken Amp-Thread-ID: https://ampcode.com/threads/T-019bed38-9b38-74b0-8aa7-70eaf424dcc6 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #rb-login-broken
Description
Session cookies were expiring immediately because the
expiresdate was calculated at server startup time. After 7+ days of server uptime, all new cookies would have an expiration date in the past, breaking login completely.Changes
expirestomaxAgein session.server.tsCurrent Tasks