test(zcash_address): Add unit tests for has_receiver_of_type, contains_receiver, and can_receive_memo#2195
Open
Cosmos-Harry wants to merge 1 commit intozcash:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The three public query methods on
unified::Address,has_receiver_of_type,contains_receiver, andcan_receive_memo, had no test coverage. This PR addsa focused unit test covering their behaviour across meaningful cases.
What's tested
has_receiver_of_typereturns correct results for Orchard, Sapling, andTransparent pool types
can_receive_memoreturnstruewhen shielded receivers are present, andfalsefor transparent-only addressescontains_receiverrequires exact byte-for-byte equality, not just type matchpool support
Unknownreceiver does not contribute to any pool type query — guardingagainst future regressions where a new receiver type might accidentally be
mapped incorrectly
Why
These methods are part of the public API and are likely called by wallets to make
decisions about memo sending and receiver selection. A silent regression here
could cause real user-facing bugs. The
Unknownreceiver case in particular isnon-obvious from reading the code alone and benefits from being pinned by a test.
Notes
No behaviour changes. Test-only.