Conversation
4edf9fe to
e7a12ea
Compare
|
Force-pushed to fix a bug and CI lints. |
| /// A Sapling return address. | ||
| ReturnAddress(PaymentAddress), |
There was a problem hiding this comment.
IIRC I copied this type code from some existing implementation of structured memos. It was Sapling-specific then, but we can easily expand its definition to be any valid recipient address encoding.
Note that this uses a byte encoding rather than a string encoding for more efficient packing, so we may need to consider how this interacts with Unified Addresses (which now exist). We don't need to serialize the network of the address, as that is implicit in the transaction (via the chain in which it is mined), so can just be provided by the caller if they want to take the address and encode it as a string.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #668 +/- ##
==========================================
- Coverage 58.74% 58.59% -0.16%
==========================================
Files 208 210 +2
Lines 27748 27873 +125
==========================================
+ Hits 16300 16331 +31
- Misses 11448 11542 +94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e7a12ea to
3114723
Compare
|
Rebased on |
Implements zcash/zips#638.
Closes #2234.
Closes COR-1121.