Skip to content

docs(openrpc): Use common crate for openrpc functionality#353

Open
oxarbitrage wants to merge 1 commit intomainfrom
openrpsee
Open

docs(openrpc): Use common crate for openrpc functionality#353
oxarbitrage wants to merge 1 commit intomainfrom
openrpsee

Conversation

@oxarbitrage
Copy link
Copy Markdown
Contributor

@oxarbitrage oxarbitrage commented Dec 18, 2025

I created a common crate for openrpc functionality: https://github.com/zcash/openrpsee as the code is shared among the Z3 stack (Zaino, Zebra, Zallet).

Added @str4d as Co-author of the first commit: zcash/openrpsee@6482040

A similar PR exist for Zebra: ZcashFoundation/zebra#10201

}

/// Static information about a Zallet JSON-RPC method.
pub(super) struct RpcMethod {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that all of this code was authored by me and copied into the openrpsee crate, I would appreciate if my authorship credit was retained therein. Also note that copyright over my contributions to this crate is owned by ECC, not me.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, sorry about that. This is something I need to ask you. My plan is to add LICENSE-APACHE and LICENSE-MIT into https://github.com/oxarbitrage/openrpsee and also squash the current commits (https://github.com/oxarbitrage/openrpsee/commits/main/) into one and add you as a Co-author of that initial commit.

Let me know if that will be enough or if you prefer something else. Thank you.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oxarbitrage
Copy link
Copy Markdown
Contributor Author

@str4d you are also welcome to give your feedback if any at zcash/openrpsee#1 for code location.

@oxarbitrage
Copy link
Copy Markdown
Contributor Author

Rebased onto main and fixed a small typo in Cargo.toml where the comment said rpc.endpoint instead of rpc.discover.

@oxarbitrage oxarbitrage force-pushed the openrpsee branch 4 times, most recently from 26e53d8 to 1ba3341 Compare March 28, 2026 21:06
@oxarbitrage
Copy link
Copy Markdown
Contributor Author

@str4d rebased onto main and bumped openrpsee to 0.1.1. The new version includes crate metadata fixes (license, repository, description) that were needed for Zallet's Docker build to pass the cargo vet / supply-chain audit step. Everything is green now (NU7 Linux failure is repo-wide). Would appreciate a review when you get a chance.

@oxarbitrage oxarbitrage requested a review from str4d March 29, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-dependencies Area: Dependencies A-documentation Area: Documentation A-rpc-interface Area: RPC interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants