docs(openrpc): Use common crate for openrpc functionality#353
docs(openrpc): Use common crate for openrpc functionality#353oxarbitrage wants to merge 1 commit intomainfrom
Conversation
| } | ||
|
|
||
| /// Static information about a Zallet JSON-RPC method. | ||
| pub(super) struct RpcMethod { |
There was a problem hiding this comment.
Given that all of this code was authored by me and copied into the openrpsee crate, I would appreciate if my authorship credit was retained therein. Also note that copyright over my contributions to this crate is owned by ECC, not me.
There was a problem hiding this comment.
Yea, sorry about that. This is something I need to ask you. My plan is to add LICENSE-APACHE and LICENSE-MIT into https://github.com/oxarbitrage/openrpsee and also squash the current commits (https://github.com/oxarbitrage/openrpsee/commits/main/) into one and add you as a Co-author of that initial commit.
Let me know if that will be enough or if you prefer something else. Thank you.
There was a problem hiding this comment.
https://github.com/oxarbitrage/openrpsee/commits/main/
Let me know if that is good enough.
|
@str4d you are also welcome to give your feedback if any at zcash/openrpsee#1 for code location. |
a2affe8 to
228a0bc
Compare
|
Rebased onto |
26e53d8 to
1ba3341
Compare
|
@str4d rebased onto main and bumped |
I created a common crate for openrpc functionality: https://github.com/zcash/openrpsee as the code is shared among the Z3 stack (Zaino, Zebra, Zallet).
Added @str4d as Co-author of the first commit: zcash/openrpsee@6482040
A similar PR exist for Zebra: ZcashFoundation/zebra#10201