[ZIP 248]: Define a forward-compatible, extensible transaction format.#1156
Open
[ZIP 248]: Define a forward-compatible, extensible transaction format.#1156
Conversation
nuttycom
force-pushed
the
draft/extensible_tx_format
branch
3 times, most recently
from
04ea4cc to
3f5566b
Compare
nuttycom
commented
Jan 21, 2026
Contributor
Author
nuttycom
left a comment
nuttycom
left a comment
There was a problem hiding this comment.
Flushing comments from ZIP editing.
nuttycom
force-pushed
the
draft/extensible_tx_format
branch
3 times, most recently
from
b26bc92 to
c7a649b
Compare
daira
reviewed
Jan 27, 2026
daira
reviewed
Jan 27, 2026
daira
reviewed
Jan 27, 2026
daira
reviewed
Jan 27, 2026
daira
reviewed
Jan 27, 2026
daira
reviewed
Jan 27, 2026
daira
reviewed
Jan 27, 2026
daira
reviewed
Jan 27, 2026
daira
reviewed
Jan 27, 2026
daira
reviewed
Jan 27, 2026
daira
reviewed
Jan 27, 2026
daira
reviewed
Jan 27, 2026
nuttycom
force-pushed
the
draft/extensible_tx_format
branch
from
2d2dffa to
29eb5b5
Compare
daira
changed the title
nuttycom
force-pushed
the
draft/extensible_tx_format
branch
5 times, most recently
from
a0020fe to
986b087
Compare
… and Orchard. Specifies the effecting and authorizing data structures for each bundle type, with value balance moved to mValuePoolDeltas as per the extensible tx format design. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ment. Specifies the V6 transaction digest algorithms: - TxId digest with separate value_pool_deltas_digest and dynamic effects_bundles_digest - Signature digest for transparent input signing with hash_type support - Authorizing data commitment for witness data Key design decisions: - Value balances committed via top-level value_pool_deltas_digest (not per-bundle) - effects_bundles_digest uses tagged concatenation (bundle_type_id || root_hash) - Unknown bundle types supported by accepting their root hash externally Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…tion process. Restructure the specification to begin with a comprehensive introduction to protocol bundles, explaining effecting data, authorizing data, and the transparent transaction value pool concepts. Define the bundle type registration process that ZIPs must follow when introducing new bundle types. Move the bundle type registry to appear before the transaction format specification for better readability. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Update PR URL to 1156 and fix email addresses - Use conformance language (MAY/MUST NOT) for registry column descriptions - Add constraint that map keys must be in increasing order - Change "ordered by" to "in increasing order of" throughout - Fix "transparent transaction value pool" terminology - Change AssetUuid subscript notation to function notation - Add registry update mechanism language - Add "Defining ZIP" column to bundle type registry table - Rephrase consensus rules section to clarify modifications to protocol spec - Add clarifying text for fee bundle semantics (coinbase collects, others pay) - Add mutual exclusion consensus rule for Sapling/Orchard bundle variants Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Register bundle type 4 (Transaction fee) in the V6 bundle registry - Update consensus rules to use mValuePoolDeltas terminology - Replace header_digest modification with value_pool_deltas_digest reference - Add reference to extensible transaction format ZIP Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Register bundle type 5 (NSM field) in the V6 bundle registry - Update consensus rules to use mValuePoolDeltas terminology - Replace header_digest modification with value_pool_deltas_digest reference - Add reference to extensible transaction format ZIP Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Register Memos, Sapling-post-ZIP 231, and Orchard-post-ZIP 231 bundle types - Update encoding section to clarify it describes effecting data - Replace Transaction sighash section with Transaction Digest referencing ZIP XXX - Specify BLAKE2b-256 personalization strings for memo digest computation - Add reference to extensible transaction format ZIP - Fix zip-0230-note-plaintexts reference Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Register ZSA Issuance bundle type in the V6 bundle registry - Update digest section to reference effects_bundles_digest and auth_bundles_digest - Add reference to extensible transaction format ZIP - Remove unused ZIP 244 and ZIP 246 references Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Register OrchardZSA bundle type in the V6 bundle registry - Update digest section to reference effects_bundles_digest and auth_bundles_digest - Add reference to extensible transaction format ZIP - Remove unused ZIP 244 and ZIP 246 references Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…uples. This makes the mutual exclusivity of bundle variants (e.g. Orchard vs OrchardZSA) implicit in the map structure, and allows clients that do not recognize a specific bundleVersion to still identify which pool is affected. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add a section to ZIP 248 describing wallet requirements for handling unknown bundle types and versions. Update ZIP 226 to reference ZIP 248 instead of ZIP 230 for transaction format and wallet implications. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nuttycom
force-pushed
the
draft/extensible_tx_format
branch
from
2397384 to
d345f8a
Compare
nuttycom
force-pushed
the
draft/extensible_tx_format
branch
from
d345f8a to
bd6f621
Compare
nuttycom
force-pushed
the
draft/extensible_tx_format
branch
from
bd6f621 to
e325e71
Compare
daira
reviewed
Apr 3, 2026
Comment on lines
+372
to
+373
| * updates to the transaction structure [#zip-0248]_ and the | ||
| sighash digest computation [#zip-0248]_; |
Collaborator
There was a problem hiding this comment.
Suggested change
| * updates to the transaction structure [#zip-0248]_ and the | |
| sighash digest computation [#zip-0248]_; | |
| * updates to the transaction structure and the sighash digest computation | |
| (both in [#zip-0248]_); |
daira
reviewed
Apr 3, 2026
| the Orchard shielded pool, because v5 transactions can only transact in the native | ||
| ZEC asset. For other consequences see ZIP 230. | ||
| * *All* wallets SHOULD be ready to receive funds in outputs of v6 transactions | ||
| as soon as ZSAs activate — in particular to support decrypting note |
Collaborator
There was a problem hiding this comment.
Suggested change
| as soon as ZSAs activate — in particular to support decrypting note | |
| as soon as v6 transactions are allowed (whether or not ZSAs activate | |
| at the same time) — in particular to support decrypting note |
daira
reviewed
Apr 3, 2026
| |-------|----------------|-----------|----------------------------------------------------------------------------| | ||
| | 8 | `zip233Amount` | `uint64` | The value to be removed from circulation in this transaction, in zatoshis. | | ||
| When the `mValuePoolDeltas` map contains an entry with `bundleType = 5`, the | ||
| transaction removes funds from circulation. The entry's `value` field MUST BE |
Collaborator
There was a problem hiding this comment.
Suggested change
| transaction removes funds from circulation. The entry's `value` field MUST BE | |
| transaction removes funds from circulation. The entry's `value` field MUST be |
daira
reviewed
Apr 3, 2026
|
|
||
| ZIP: 248 | ||
| Title: Extensible Transaction Format | ||
| Owners: Jack Grigg <jack@znewco.com> |
Collaborator
There was a problem hiding this comment.
Suggested change
| Owners: Jack Grigg <jack@znewco.com> | |
| Owners: Jack Grigg <thestr4d@gmail.com> |
daira
reviewed
Apr 3, 2026
Comment on lines
+19
to
+20
| {Edit this to reflect the key words that are actually used.} | ||
| The key words "MUST", "REQUIRED", "MUST NOT", "SHOULD", and "MAY" in this |
Collaborator
There was a problem hiding this comment.
Suggested change
| {Edit this to reflect the key words that are actually used.} | |
| The key words "MUST", "REQUIRED", "MUST NOT", "SHOULD", and "MAY" in this | |
| The key words "MUST", "MUST NOT", "SHOULD", and "MAY" in this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1163