Open
Conversation
Introduces a new informational draft ZIP for Orchard Proof-of-Balance, enabling users to prove the total value of their Orchard notes without revealing individual note details.
czarcas7ic
changed the title
str4d
added
the
S-waiting-on-review
Co-authored-by: Jack Grigg <thestr4d@gmail.com>
Co-authored-by: Jack Grigg <thestr4d@gmail.com>
czarcas7ic
added a commit
to valargroup/voting-circuits
that referenced
this pull request
Mar 23, 2026
Three changes to align with zcash/zips#1199: 1. Governance nullifier → alternate nullifier with explicit dom public input (14th instance field). dom = Poseidon("governance authorization", vote_round_id) derived out-of-circuit. In-circuit: Poseidon(nk, dom, real_nf) with ConstantLength<3>. 2. Dummy signed note value 0 → 1 to match PCZT construction. 3. Replace is_note_real with v * (root - anchor) = 0 (Orchard standard dummy note mechanism). Remove condition 15.
czarcas7ic
added a commit
to valargroup/librustvoting
that referenced
this pull request
Mar 23, 2026
Align derive_gov_nullifier with the new alternate nullifier formula from zcash/zips#1199. Takes dom instead of vote_round_id as second parameter. Adds compute_nullifier_domain() to derive dom out-of-circuit. Formula: Poseidon(nk, dom, nf) with ConstantLength<3>.
czarcas7ic
added a commit
to valargroup/voting-circuits
that referenced
this pull request
Mar 23, 2026
Three changes to align with zcash/zips#1199: 1. Governance nullifier → alternate nullifier with explicit dom public input (14th instance field). dom = Poseidon("governance authorization", vote_round_id) derived out-of-circuit. In-circuit: Poseidon(nk, dom, real_nf) with ConstantLength<3>. 2. Dummy signed note value 0 → 1 to match PCZT construction. 3. Replace is_note_real with v * (root - anchor) = 0 (Orchard standard dummy note mechanism). Remove condition 15.
czarcas7ic
added a commit
to valargroup/voting-circuits
that referenced
this pull request
Mar 23, 2026
Three changes to align with zcash/zips#1199: 1. Governance nullifier → alternate nullifier with explicit dom public input (14th instance field). dom = Poseidon("governance authorization", vote_round_id) derived out-of-circuit. In-circuit: Poseidon(nk, dom, real_nf) with ConstantLength<3>. 2. Dummy signed note value 0 → 1 to match PCZT construction. 3. Replace is_note_real with v * (root - anchor) = 0 (Orchard standard dummy note mechanism). Remove condition 15.
str4d
removed
the
S-waiting-on-review
str4d
dismissed
their stale review
I'm unable to continue reviewing this, so dismissing my review to ensure it doesn't block merging. Someone else needs to review to confirm my comments were addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
draft-valargroup-orchard-balance-proof.md) specifying the Orchard Proof-of-Balance protocol, which is intended to be used in a future Zcash voting application.draft-str4d-orchard-balance-proof.md)