Conversation
|
@MrSubidubi Could you review please! |
|
Sorry for the lack of reply here. I'd very much like @PKief s opinion here (hope that is fine for you), as I think we'd probably need to add this upstream if he is fine with it. |
|
@MrSubidubi That will be okay |
|
Thanks for your contribution, really appreciate the effort here! In general, creating a new icon upstream in material-extensions/vscode-material-icon-theme would be the preferred approach. That said, there are a couple of constraints to keep in mind:
As an alternative, we could consider including the icons directly in this PR. However, that would require some adjustments to the upstream sync script, since it currently overwrites the existing JSON file. Let me know what you think — happy to discuss possible approaches 👍 |
|
@PKief I agree. I would better redesign the icons which goes better with the theme. So I'm closing from here. |
This pull request adds support for Ferret language and manifest file icons to the
material-icon-theme. The changes include new icon definitions and mappings for Ferret-related file extensions.Icon additions:
ferret.svg) and Ferret manifest files (ferret_mod.svg).File extension mappings:
.ferfile extension with the new Ferret icon.fer.retmanifest file with the new Ferret manifest icon.