Fix ActiveRecord::Base.clear_on_handler#104
Merged
Conversation
Fix the patch for `ActiveRecord::Base.clear_on_handler` to work correctly right after the creation of a new connection pool. In doing this, we add `ActiveRecordHostPool::PoolProxy#_unproxied_connection` which gives access to the underlying, "real", shared connection without going through the connection proxy, which would call `#_host_pool_current_database=` on the underlying connection. Co-authored-by: Nony Dutton <nony.dutton@zendesk.com>
HeyNonster
approved these changes
Jan 18, 2023
We don't want to accidentally test on Ruby 3.2, just because `3.0` is coerced into `3`.
HeyNonster
approved these changes
Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the patch for
ActiveRecord::Base.clear_on_handlerto work correctly right after the creation of a new connection pool.In doing this, we add
ActiveRecordHostPool::PoolProxy#_unproxied_connectionwhich gives access to the underlying, "real", shared connection without going through the connection proxy, which would call#_host_pool_current_database=on the underlying connection.