make iab-vast-parser compatible with new version of iab-vast-model#48
Open
laurentdesmet wants to merge 3 commits intomasterfrom
Open
make iab-vast-parser compatible with new version of iab-vast-model#48laurentdesmet wants to merge 3 commits intomasterfrom
laurentdesmet wants to merge 3 commits intomasterfrom
Conversation
timdp
approved these changes
Jul 31, 2017
added 2 commits
September 5, 2017 11:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the newly typed VAST model as implemented in zentrick/iab-vast-model#39. This contains some breaking changes that required changes in the parser. This should be published using a new major version as this contains breaking changes.