stm32cube: stm32fx: remove phy init and config

[maass-hamburg]

remove phy init and config from the legacy ethernet hal,
as that is already done in zephyr before and we don't want it to
be overwritten

[erwango]

There are 2 options coming to HAL usage. Either using it untouched, either not using it. I'm not keen on opening the door to this kind of modification.

[maass-hamburg]

unfortunately ETH_MACDMAConfig is a static function and not exposed, so would also have to copy that over to zephyr, that would not only be ugly but also have some copyright problems, as the hal is not under the Apache 2.0 Licence or any other OSS license. If that is the only option I would leave that for somebody else to do and close this and the PR in zephyr related to this.

There are already other patches in the hal and this one would be pretty easy to reapply, as it is just removing a big block from one function.

[erwango]

unfortunately ETH_MACDMAConfig is a static function and not exposed, so would also have to copy that over to zephyr, that would not only be ugly but also have some copyright problems, as the hal is not under the Apache 2.0 Licence or any other OSS license. If that is the only option I would leave that for somebody else to do and close this and the PR in zephyr related to this.

There are already other patches in the hal and this one would be pretty easy to reapply, as it is just removing a big block from one function.

I'll take some time to think about it and specially how to do it while not opening a can of worms by letting think anyone can patch HAL whenever this is the easiest solution.

[erwango]

@maass-hamburg I did not forget about this one, I'll provide a feedback soon.

[maass-hamburg]

@erwango How is it going?

[erwango]

Thanks for reminding me about this.

As this is quite specific to these 2 pieces of HW, I'm fine doing the change.
Though, please use #ifndef ZEPHYR directive.
This will make rebase easier if this piece of "upstream" code gets updates.

[juickar]

These changes look good to me
Tested on stm32f207zg with the dhcpv4 client sample