stm32wba : ble-802.15.4 concurrent mode integration by vtardy-st · Pull Request #319 · zephyrproject-rtos/hal_stm32

vtardy-st · 2025-10-17T08:05:33Z

Integration of the BLE-802.15.4 concurrent mode on stm32wba based on CubeWBA release 1.7.0

lib/stm32wba/CMakeLists.txt

asm5878 · 2025-11-12T08:53:38Z

lib/stm32wba/README.rst

+
+   * Discard "static" implementation of ll_sys_bg_temperature_measurement_init to allow specific zephyr implementation
+      Impacted file: ll_sys_if.c
+                     ll_sys.h


It seems no real change here, we could revert ?

This change has been reverted

asm5878 · 2025-11-12T09:17:08Z

Hello @mathieuchopstm and @etienne-lms. Could you please have a look ?

mathieuchopstm

Some refinement needed but seems overall OK

lib/stm32wba/concurrent/Core/Inc/app_conf/app_conf.h

mathieuchopstm · 2025-11-12T09:33:42Z

lib/stm32wba/RF_Integration/Core/Inc/app_conf/app_conf.h

+#ifndef __ZEPHYR__
+#define RADIO_SW_LOW_INTR_PRIO              (15)           /* 2.4GHz RADIO low ISR priority */
+#else
+#define RADIO_SW_LOW_INTR_PRIO              (14)           /* 2.4GHz RADIO low ISR priority */
+#endif


Interrupt priority should come from DT anyways so I'm a bit surprised this is needed.

This interrupt priority constant is used in the link_layer_register_isr() function defined in zephyr\soc\st\stm32\stm32wbax\hci_if\linklayer_plat_adapt.c
If change should be done, it will be done in another PR

mathieuchopstm · 2025-11-12T09:37:33Z

lib/stm32wba/concurrent/Core/Inc/app_common.h

+#ifndef MAX
+#define MAX( x, y )          (((x)>(y))?(x):(y))
+#endif
+
+#ifndef MIN
+#define MIN( x, y )          (((x)<(y))?(x):(y))
+#endif


If this header is visible from the Zephyr side, please use an approach similar to VCNano8000e stack instead: add private compile definition for the library only and gate these behind the private definition

hal_stm32/lib/vc8000nanoe/CMakeLists.txt

Lines 4 to 6 in 286dd28

zephyr_library()

zephyr_library_compile_definitions(H1_INTERNAL)

hal_stm32/lib/vc8000nanoe/inc/enccommon.h

Lines 156 to 159 in 286dd28

#ifdef H1_INTERNAL

#define MAX(a, b) ((a) > (b) ? (a) : (b))

#define MIN(a, b) ((a) < (b) ? (a) : (b))

#endif

This implementation is herited from CubeMx

lib/stm32wba/CMakeLists.txt

lib/stm32wba/STM32_WPAN/link_layer/ll_sys/src/ll_sys_startup.c

lib/stm32wba/concurrent/Core/Inc/app_common.h

etienne-lms · 2025-11-13T13:44:40Z

lib/stm32wba/concurrent/STM32_WPAN/Target/bpka.c

+
+    BPKA_error = 0;
+
+    break;


Preferably with default case in switch/case instructions.

This code is heritated from CubeMx. Do you think this change is required ?

lib/stm32wba/CMakeLists.txt

mathieuchopstm · 2025-11-13T15:18:39Z

I can't mark conversations are resolved so I added 🚀 reaction to my own "resolved" messages instead.

erwango · 2025-11-18T10:43:55Z

@vtardy-st Please rebase

zephyr/module.yml

lib/stm32wba/RF_Integration/STM32_WPAN/Target/linklayer_plat.c

lib/stm32wba/concurrent/STM32_WPAN/Target/bpka.c

…ries Add WBA6_LinkLayer_BLE_Basic_15_4_lib_Zephyr.a and WBA6_LinkLayer_BLE_Full_15_4_lib_Zephyr.a Signed-off-by: Vincent Tardy <vincent.tardy@st.com>

lib/stm32wba/RF_Integration/STM32_WPAN/Target/linklayer_plat.c

erwango

Combination of:

files duplicated depending on the use case (see comment)
functions adapted in place instead of in zephyr as it should actually be done (see comment)

makes the libraries more and more complex to review and maintain.
I don't think this is the right direction and approach should be reviewed.

lib/stm32wba/RF_Integration/Core/Inc/app_conf/app_conf.h

erwango

Thanks for the update. This is going in the good direction. I guess we can fix the remaining issue of Zephyr adaptation done in this repo instead of zephyr/ in a next repo.

Looking to https://github.com/vtardy-st/hal_stm32/blob/stm32wba_1_7_0_ble_802154_concurrent/lib/stm32wba/README.rst, there is indentation issues to fix to have the file readable, it would be nice to fix this (as an additional commit for issues that are not coming from current PR)

Otherwise LGTM

lib/stm32wba/README.rst

mathieuchopstm

Two minor nits + #319 (comment) left to address.

I think these are non-blocking though.

mathieuchopstm · 2025-11-28T13:23:59Z

lib/stm32wba/RF_Integration/STM32_WPAN/Target/linklayer_plat.c

+#ifndef __ZEPHYR__
+  uint32_t linklayer_slp_clk_src = LL_RCC_RADIOSLEEPSOURCE_NONE;

-#ifdef __ZEPHYR__
-	LINKLAYER_PLAT_EnableBackupDomainAccess();
+  /* Get the Link Layer sleep timer clock source */
+  linklayer_slp_clk_src = LL_RCC_RADIO_GetSleepTimerClockSource();
+  if(linklayer_slp_clk_src == LL_RCC_RADIOSLEEPSOURCE_NONE)
+  {
+    /* If there is no clock source defined, should be selected before */
+    assert_param(0);
+  }


Should be tabs indentations

Indentation type is this file is herited from STM32Cube

mathieuchopstm · 2025-11-28T13:24:29Z

lib/stm32wba/RF_Integration/STM32_WPAN/Target/linklayer_plat.c

+  /* Enable AHB5ENR peripheral clock (bus CLK) */
+  __HAL_RCC_RADIO_CLK_ENABLE();


Keep tabs as indentation

Suggested change

/* Enable AHB5ENR peripheral clock (bus CLK) */

__HAL_RCC_RADIO_CLK_ENABLE();

/* Enable AHB5ENR peripheral clock (bus CLK) */

__HAL_RCC_RADIO_CLK_ENABLE();

Indentation type is this file is herited from STM32Cube

Add support of ble-ieee 802.15.4 concurrent mode Signed-off-by: Vincent Tardy <vincent.tardy@st.com>

Porting of modes ble, ieee 802.15.4 and concurrent are refactorised in one unique RF_Integration folder supporting the 3 different mode configurations. Signed-off-by: Vincent Tardy <vincent.tardy@st.com>

Rework the README.rst file to fix indentation issues. Signed-off-by: Vincent Tardy <vincent.tardy@st.com>

github-actions bot mentioned this pull request Oct 17, 2025

stm32wba : ble-802.15.4 concurrent mode integration zephyrproject-rtos/zephyr#97773

Merged

vtardy-st marked this pull request as draft October 17, 2025 09:33

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from 131fbdb to 7cb891e Compare October 17, 2025 10:02

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch 2 times, most recently from 628d59a to f48981b Compare November 4, 2025 11:29

vtardy-st marked this pull request as ready for review November 4, 2025 13:00

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from f48981b to e29c333 Compare November 10, 2025 15:20

asm5878 self-requested a review November 12, 2025 07:30

asm5878 reviewed Nov 12, 2025

View reviewed changes

lib/stm32wba/CMakeLists.txt Show resolved Hide resolved

asm5878 reviewed Nov 12, 2025

View reviewed changes

asm5878 requested review from HoZHel and erwango November 12, 2025 09:09

asm5878 assigned erwango Nov 12, 2025

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from e29c333 to 8f70ccc Compare November 12, 2025 09:25

mathieuchopstm reviewed Nov 12, 2025

View reviewed changes

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from 8f70ccc to c059c4c Compare November 12, 2025 15:02

etienne-lms reviewed Nov 13, 2025

View reviewed changes

mathieuchopstm reviewed Nov 13, 2025

View reviewed changes

lib/stm32wba/CMakeLists.txt Outdated Show resolved Hide resolved

lib/stm32wba/CMakeLists.txt Show resolved Hide resolved

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from c059c4c to ac58b83 Compare November 13, 2025 16:57

vtardy-st requested review from asm5878, etienne-lms and mathieuchopstm November 17, 2025 08:14

mathieuchopstm mentioned this pull request Nov 17, 2025

Fix link layer selection for STM32WBA52XX #326

Merged

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from ac58b83 to 7229677 Compare November 18, 2025 12:59

erwango requested changes Nov 25, 2025

View reviewed changes

zephyr/module.yml Outdated Show resolved Hide resolved

lib/stm32wba/RF_Integration/STM32_WPAN/Target/linklayer_plat.c Show resolved Hide resolved

lib/stm32wba/concurrent/STM32_WPAN/Target/bpka.c Outdated Show resolved Hide resolved

lib: blobs: add stm32wba ble-ieee802.15.4 concurrent Link Layer libra…

741e436

…ries Add WBA6_LinkLayer_BLE_Basic_15_4_lib_Zephyr.a and WBA6_LinkLayer_BLE_Full_15_4_lib_Zephyr.a Signed-off-by: Vincent Tardy <vincent.tardy@st.com>

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from 7229677 to d271137 Compare November 25, 2025 15:31

erwango requested changes Nov 26, 2025

View reviewed changes

lib/stm32wba/RF_Integration/STM32_WPAN/Target/linklayer_plat.c Show resolved Hide resolved

erwango requested changes Nov 26, 2025

View reviewed changes

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from 69d663c to d9dbc78 Compare November 26, 2025 13:43

erwango reviewed Nov 27, 2025

View reviewed changes

lib/stm32wba/RF_Integration/Core/Inc/app_conf/app_conf.h Show resolved Hide resolved

erwango requested changes Nov 27, 2025

View reviewed changes

lib/stm32wba/README.rst Outdated Show resolved Hide resolved

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from d9dbc78 to f7b46f3 Compare November 27, 2025 12:57

erwango approved these changes Nov 27, 2025

View reviewed changes

mathieuchopstm approved these changes Nov 28, 2025

View reviewed changes

vtardy-st added 3 commits November 28, 2025 15:13

lib: stm32wba: ble-802.15.4 concurrent mode integration

0463d72

Add support of ble-ieee 802.15.4 concurrent mode Signed-off-by: Vincent Tardy <vincent.tardy@st.com>

lib: stm32wba: ble-802.15.4 integration refactoring

af090f0

Porting of modes ble, ieee 802.15.4 and concurrent are refactorised in one unique RF_Integration folder supporting the 3 different mode configurations. Signed-off-by: Vincent Tardy <vincent.tardy@st.com>

lib: stm32wba: README.rst rework

5c66606

Rework the README.rst file to fix indentation issues. Signed-off-by: Vincent Tardy <vincent.tardy@st.com>

vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from f41c870 to 5c66606 Compare November 28, 2025 14:14

erwango merged commit 50fcec6 into zephyrproject-rtos:main Nov 28, 2025
2 checks passed

vtardy-st deleted the stm32wba_1_7_0_ble_802154_concurrent branch March 11, 2026 14:06

	zephyr_library()

	zephyr_library_compile_definitions(H1_INTERNAL)

	#ifdef H1_INTERNAL
	#define MAX(a, b) ((a) > (b) ? (a) : (b))
	#define MIN(a, b) ((a) < (b) ? (a) : (b))
	#endif

		/* Enable AHB5ENR peripheral clock (bus CLK) */
		__HAL_RCC_RADIO_CLK_ENABLE();

Conversation

vtardy-st commented Oct 17, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

asm5878 commented Nov 12, 2025

Uh oh!

mathieuchopstm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mathieuchopstm commented Nov 13, 2025

Uh oh!

erwango commented Nov 18, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erwango left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

erwango left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mathieuchopstm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

erwango left a comment •

edited

Loading