fix(dave2d): Add handle for support input format on Zephyr#67
fix(dave2d): Add handle for support input format on Zephyr#67duynguyenxa wants to merge 1 commit intozephyrproject-rtos:masterfrom
Conversation
Signed-off-by: Duy Nguyen <duy.nguyen.xa@renesas.com>
|
For CI purposes this fine, but we want the module to be 1:1 copy of upstream on the master branch. Therefore your change needs to be submitted upstream first. However this good to test the changes in zephyr repo as well. |
|
hi @faxe1008 , it's seem that on the upstream the function is removed so this patched is no longer required, may I know when there will be update to Zephyr fork from lvgl upstream? |
|
I plan to do it soonish, as v9.4 will be released tomorrow |
|
@duynguyenxa took a bit longer then expected, but module PR was merged today. |
uLipe
left a comment
There was a problem hiding this comment.
Tested on my RA8D1 and works as intended.
Should we target the upstream with this PR too?
|
I looked into your patch as it is in my backlog and wanted to attempt to upstream a more generalized version. But it seems this change here depends on the HAL changes you proposed over here: But it hardcodes the pixel format used to be the one of chosen display. Since we now support multiple displays I kinda want this to work with any display. I will see if I can propose a more generalized solution. |
|
Investigating a possible solution I saw that @uLipe already tackeled the issue with a general approach: Can you confirm @duynguyenxa that this resolves the issue you were trying to solve with this patch? It would allow you to clean your HAL PR as well. |
|
@duynguyenxa no worries. Congratulations 🥳 |
This commit is to support DRW accelerator for Renesas devices on Zephyr
If Zephyr is used the
lv_draw_dave2d_cf_fb_getwill get input format from device tree informationThe macro to get the information is located at: https://github.com/zephyrproject-rtos/hal_renesas/pull/154/files#diff-de6e3e3502685f19aeefcf9bb9c021b19c0b4bfa5a8cbb49641c324f7e66f780R35