security: prevent path traversal in ezcCacheStorageFile::generateIdentifier()#4
Open
se7enxweb wants to merge 1 commit intozetacomponents:masterfrom
Open
security: prevent path traversal in ezcCacheStorageFile::generateIdentifier()#4se7enxweb wants to merge 1 commit intozetacomponents:masterfrom
se7enxweb wants to merge 1 commit intozetacomponents:masterfrom
Conversation
…tifier() The method replaced '/' with DIRECTORY_SEPARATOR but never canonicalized the resulting path, so IDs containing '..' sequences could escape the configured cache location directory. Fix: after building the identifier string, resolve the target directory with realpath() and verify it starts with the cache base directory. ezcBaseValueException is thrown if the resolved path escapes the base. Reported-by: CJW Network security audit 2026-03-01 Security-fixes: path-traversal (CWE-22)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported-by: CJW Network security audit 2026-03-01
Problem
generateIdentifier()replaces/withDIRECTORY_SEPARATORbut never canonicalises the resulting path. An ID containing..sequences can escape the configured cache$locationdirectory, causing cache reads/writes/deletes outside the intended directory.Changes
src/storage/file.phpAfter building the identifier string, resolve the target directory with
realpath()and verify it starts with the cache base directory. ThrowezcBaseValueExceptionif the resolved path escapes the base.Security fixes