Make tests PHP & PHPUnit cross-version compatible ?

[jrfnl]

I noticed PR #10 which is sort of about the same, though it would inhibit the tests from being run on PHP 5.6, which is still listed in the Travis script.

The short of it is that it will be neigh impossible to get the tests running on PHP 8.1 with PHPUnit 7.x, which is the current setup.

As this package still supports older PHP versions, it would be opportune to make the cross-version compatible.

This can be done in various ways, though I'd like to suggest to use the PHPUnit Polyfills, though I'm biased 😂 (I wrote that package).

The PHPUnit Polyfills package can sort out most issues, in particular it:

• Polyfills all assertions and expectation methods introduced in PHPUnit since PHPUnit 5.0 to current (PHPUnit 9.5). This allows for the test suite to use the currently available set of assertion and expectation methods, while allowing the tests to still run on PHPUnit 4.x-8.x.
• Includes a TestCase which can be extended with a solution for the void return type being added in PHPUnit 8.
• Includes a PHPUnit cross-version compatible way of implementing TestListeners.

I haven't looked at the tests in-depth yet, but I suspect that the Polyfills package can sort out most, if not all, issues for making the test suite cross-version compatible.

[derickr]

I don't really want to go the polyfills way, sorry. I think for this package, I'd be happy to just have it running with PHPUnit 8. I've just pushed a commit to change it to use that, but as I commented in #10, there are some warnings that need to be sorted out. I think replacing them with the PHPUnit 8 equivalent would do fine.

If there is something tangible that PHPUnit Polyfills can still solve, I'm not opposed to it either, but I'm not much interested in continuing to have to care for old versions of PHPUnit (4-7), or supporting pre-7.2 PHP versions.

[jrfnl]

I don't really want to go the polyfills way, sorry. I think for this package, I'd be happy to just have it running with PHPUnit 8.

That's fine. I based my suggestion on the impression I got from the Travis script that the tests should still be run on PHP 5.6. If that's not the case and you're happy to have a PHP 7.2 minimum for the tests, you don't need the Polyfills package.

I think replacing them with the PHPUnit 8 equivalent would do fine.

There is no PHPUnit 8 equivalent for these. Those assertions were deprecated/removed from PHPUnit without replacement as they allowed for testing the value of private/protected properties.

For public properties, the assertions can be replaced with a plain assert[Equals|Same]($expected, $obj->property). For protected/private properties, the Polyfills does offer a bridge-gap solution, but the recommendation is still to refactor the tests/code to not use assertions on private/protected properties. A getter method in the class under test for private/protected properties could sort this out, for instance.

[derickr]

Is this still a relevant issue?

[jrfnl]

I don't know, is it ?