Render organizer message in CallListItem#1037
Open
MikaelJohnAndersson wants to merge 7 commits into
Open
Conversation
Collaborator
|
Would it be possible to include a screenshot? I can't test it myself on my local machine atm. |
Contributor
Author
|
@jensborje Sure! I updated the PR with added screenshots. |
jensborje
approved these changes
Jan 30, 2020
jensborje
left a comment
jensborje
left a comment
Collaborator
There was a problem hiding this comment.
Very good! Well done!
martinajsongren
requested changes
Feb 2, 2020
martinajsongren
left a comment
martinajsongren
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, but I left a comment where you missed a semicolon.
martinajsongren
approved these changes
Feb 2, 2020
| ); | ||
| } | ||
| else if (call.message_to_organizer && call.message_to_organizer.length > 180) { | ||
| messageContent = call.message_to_organizer.substr(0, 180) + '...'; |
Member
There was a problem hiding this comment.
How about something like this?
let len = 0;
messageContent = call.message_to_organizer.split(' ').filter(s => (len += s.length + 1) && len < 40).join(' ') + '...';
| 0% { content: '.'; } | ||
| 33% { content: '..'; } | ||
| 66% { content: '...'; } | ||
| 99% { content: '.'; } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds functionality for displaying the message to organizer in
CallListItem.Since
message_to_organizeronly is included in the data when retrieving a single call,CallListItemdispatches an action for retrieving additional data once the item is in view, displaying a loading (dots) animation while the request is pending.In cases where there is no
message_to_organizerdata, a fallback message is rendered.Examples of truncated message, full message and message placeholder:
Loading animation:
Closes #933