Skip to content

Add qdrant CLI support and fix support for optional fields#519

Merged
alwayslove2013 merged 1 commit intozilliztech:mainfrom
s-h-a-d-o-w:add-qdrant-cli
May 9, 2025
Merged

Add qdrant CLI support and fix support for optional fields#519
alwayslove2013 merged 1 commit intozilliztech:mainfrom
s-h-a-d-o-w:add-qdrant-cli

Conversation

@s-h-a-d-o-w
Copy link
Copy Markdown
Contributor

While working on CLI support using qdrant's docker image, I came across the problem that the current implementation to support empty strings actually doesn't seem to work. Using an empty string resulted in the following error:

  File "C:\Users\andy\temp\VectorDBBench\vectordb_bench\backend\clients\qdrant_cloud\cli.py", line 39, in QdrantCloud
    db_config=QdrantConfig(**config_params),
              ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "pydantic\\main.py", line 347, in pydantic.main.BaseModel.__init__
pydantic.error_wrappers.ValidationError: 1 validation error for QdrantConfig
api_key
  none is not an allowed value (type=type_error.none.not_allowed)

I guess pydantic interprets empty strings as None?
To resolve this, I made this field actually optional (instead of relying on empty string) and added handling for optional fields to the frontend.

If you like these changes, what do you think about renaming things to just "qdrant" (no "cloud") and making http://localhost:6333 the default value for url?

@sre-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alwayslove2013, s-h-a-d-o-w
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alwayslove2013 alwayslove2013 merged commit 31b8cbd into zilliztech:main May 9, 2025
4 checks passed
@s-h-a-d-o-w s-h-a-d-o-w deleted the add-qdrant-cli branch May 9, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants