Add qdrant CLI support and fix support for optional fields#519
Merged
alwayslove2013 merged 1 commit intozilliztech:mainfrom May 9, 2025
Merged
Add qdrant CLI support and fix support for optional fields#519alwayslove2013 merged 1 commit intozilliztech:mainfrom
alwayslove2013 merged 1 commit intozilliztech:mainfrom
Conversation
alwayslove2013
approved these changes
May 9, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alwayslove2013, s-h-a-d-o-w The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on CLI support using qdrant's docker image, I came across the problem that the current implementation to support empty strings actually doesn't seem to work. Using an empty string resulted in the following error:
I guess pydantic interprets empty strings as None?
To resolve this, I made this field actually optional (instead of relying on empty string) and added handling for optional fields to the frontend.
If you like these changes, what do you think about renaming things to just "qdrant" (no "cloud") and making
http://localhost:6333the default value forurl?