Skip to content

feat: add avg serial latency output #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ztorchan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add avg serial latency output #734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions vectordb_bench/backend/runner/read_write_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,10 @@ def run_search(self, perc: int):
log.info("Search after write - Serial search start")
test_time = round(time.perf_counter(), 4)
res, ssearch_dur = self.serial_search_runner.run()
recall, ndcg, p99_latency, p95_latency = res
recall, ndcg, p99_latency, p95_latency, avg_latency = res
log.info(
f"Search after write - Serial search - recall={recall}, ndcg={ndcg}, "
f"p99={p99_latency}, p95={p95_latency}, dur={ssearch_dur:.4f}",
f"p99={p99_latency}, p95={p95_latency}, avg={avg_latency}, dur={ssearch_dur:.4f}",
)
log.info(
f"Search after wirte - Conc search start, dur for each conc={self.read_dur_after_write}",
Expand All @@ -125,6 +125,7 @@ def run_search(self, perc: int):
ndcg,
p99_latency,
p95_latency,
avg_latency,
conc_failed_rate,
conc_num_list,
conc_qps_list,
Expand Down Expand Up @@ -181,14 +182,15 @@ def run_read_write(self) -> Metric:
m.st_ndcg_list = [d[4] for d in r]
m.st_serial_latency_p99_list = [d[5] for d in r]
m.st_serial_latency_p95_list = [d[6] for d in r]
m.st_conc_failed_rate_list = [d[7] for d in r]
m.st_serial_latency_avg_list = [d[7] for d in r]
m.st_conc_failed_rate_list = [d[8] for d in r]

# Extract concurrent latency data
m.st_conc_num_list_list = [d[8] for d in r]
m.st_conc_qps_list_list = [d[9] for d in r]
m.st_conc_latency_p99_list_list = [d[10] for d in r]
m.st_conc_latency_p95_list_list = [d[11] for d in r]
m.st_conc_latency_avg_list_list = [d[12] for d in r]
m.st_conc_num_list_list = [d[9] for d in r]
m.st_conc_qps_list_list = [d[10] for d in r]
m.st_conc_latency_p99_list_list = [d[11] for d in r]
m.st_conc_latency_p95_list_list = [d[12] for d in r]
m.st_conc_latency_avg_list_list = [d[13] for d in r]

except Exception as e:
log.warning(f"Read and write error: {e}")
Expand Down Expand Up @@ -262,10 +264,10 @@ def wait_next_target(start: int, target_batch: int) -> bool:
log.info(f"[{target_batch}/{total_batch}] Serial search - {perc}% start")
res, ssearch_dur = self.serial_search_runner.run()
ssearch_dur = round(ssearch_dur, 4)
recall, ndcg, p99_latency, p95_latency = res
recall, ndcg, p99_latency, p95_latency, avg_latency = res
log.info(
f"[{target_batch}/{total_batch}] Serial search - {perc}% done, "
f"recall={recall}, ndcg={ndcg}, p99={p99_latency}, p95={p95_latency}, dur={ssearch_dur}"
f"recall={recall}, ndcg={ndcg}, p99={p99_latency}, p95={p95_latency}, avg={avg_latency}, dur={ssearch_dur}"
)

each_conc_search_dur = self.get_each_conc_search_dur(
Expand Down Expand Up @@ -299,6 +301,7 @@ def wait_next_target(start: int, target_batch: int) -> bool:
ndcg,
p99_latency,
p95_latency,
avg_latency,
conc_failed_rate,
conc_num_list,
conc_qps_list,
Expand Down
6 changes: 3 additions & 3 deletions vectordb_bench/backend/runner/serial_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ def _get_db_search_res(self, emb: list[float], retry_idx: int = 0) -> list[int]:

return results

def search(self, args: tuple[list, list[list[int]]]) -> tuple[float, float, float, float]:
def search(self, args: tuple[list, list[list[int]]]) -> tuple[float, float, float, float, float]:
log.info(f"{mp.current_process().name:14} start search the entire test_data to get recall and latency")
with self.db.init():
self.db.prepare_filter(self.filters)
Expand Down Expand Up @@ -292,15 +292,15 @@ def search(self, args: tuple[list, list[list[int]]]) -> tuple[float, float, floa
f"p99={p99}, "
f"p95={p95}"
)
return (avg_recall, avg_ndcg, p99, p95)
return (avg_recall, avg_ndcg, p99, p95, avg_latency)

def _run_in_subprocess(self) -> tuple[float, float, float, float]:
with concurrent.futures.ProcessPoolExecutor(max_workers=1) as executor:
future = executor.submit(self.search, (self.test_data, self.ground_truth))
return future.result()

@utils.time_it
def run(self) -> tuple[float, float, float, float]:
def run(self) -> tuple[float, float, float, float, float]:
log.info(f"{mp.current_process().name:14} start serial search")
if self.test_data is None:
msg = "empty test_data"
Expand Down
4 changes: 2 additions & 2 deletions vectordb_bench/backend/task_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ def _run_perf_case(self, drop_old: bool = True) -> Metric:
) = search_results
if TaskStage.SEARCH_SERIAL in self.config.stages:
search_results = self._serial_search()
m.recall, m.ndcg, m.serial_latency_p99, m.serial_latency_p95 = search_results
m.recall, m.ndcg, m.serial_latency_p99, m.serial_latency_p95, m.serial_latency_avg = search_results

except Exception as e:
log.warning(f"Failed to run performance case, reason = {e}")
Expand Down Expand Up @@ -256,7 +256,7 @@ def _load_train_data(self):
finally:
runner = None

def _serial_search(self) -> tuple[float, float, float, float]:
def _serial_search(self) -> tuple[float, float, float, float, float]:
"""Performance serial tests, search the entire test data once,
calculate the recall, serial_latency_p99, serial_latency_p95

Expand Down
2 changes: 2 additions & 0 deletions vectordb_bench/metric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ class Metric:
qps: float = 0.0
serial_latency_p99: float = 0.0
serial_latency_p95: float = 0.0
serial_latency_avg: float = 0.0
recall: float = 0.0
ndcg: float = 0.0
conc_num_list: list[int] = field(default_factory=list)
Expand All @@ -39,6 +40,7 @@ class Metric:
st_ndcg_list: list[float] = field(default_factory=list)
st_serial_latency_p99_list: list[float] = field(default_factory=list)
st_serial_latency_p95_list: list[float] = field(default_factory=list)
st_serial_latency_avg_list: list[float] = field(default_factory=list)
st_conc_failed_rate_list: list[float] = field(default_factory=list)

# for streaming cases - concurrent latency data per stage
Expand Down
7 changes: 7 additions & 0 deletions vectordb_bench/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,11 @@ def read_file(cls, full_path: pathlib.Path, trans_unit: bool = False) -> Self:
case_result["metrics"]["serial_latency_p99"] = (
cur_latency * 1000 if cur_latency > 0 else cur_latency
)

cur_latency = case_result["metrics"]["serial_latency_avg"]
Copy link
Copy Markdown
Collaborator

@xiaofan-luan xiaofan-luan Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a if check for backward compatibility

if "serial_latency_avg" in case_result["metrics"]

case_result["metrics"]["serial_latency_avg"] = (
cur_latency * 1000 if cur_latency > 0 else cur_latency
)

# Handle P95 latency for backward compatibility with existing result files
if "serial_latency_p95" in case_result["metrics"]:
Expand Down Expand Up @@ -438,6 +443,7 @@ def append_return(x: any, y: any):
"qps",
"latency(p99)",
"latency(p95)",
"latency(avg)",
"recall",
"max_load_count",
"label",
Expand All @@ -461,6 +467,7 @@ def append_return(x: any, y: any):
f.metrics.qps,
f.metrics.serial_latency_p99,
f.metrics.serial_latency_p95,
f.metrics.serial_latency_avg,
f.metrics.recall,
f.metrics.max_load_count,
f.label.value,
Expand Down
Loading
⚡