feat:object storage aksk uses k8s secret storage#257
Open
doubledna wants to merge 1 commit intozilliztech:masterfrom
Open
feat:object storage aksk uses k8s secret storage#257doubledna wants to merge 1 commit intozilliztech:masterfrom
doubledna wants to merge 1 commit intozilliztech:masterfrom
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: doubledna The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Collaborator
|
Welcome @doubledna! It looks like this is your first PR to zilliztech/milvus-helm 🎉 |
doubledna
requested review from
LoveEachDay
and removed request for
LoveEachDay and
haorenfsa
doubledna
force-pushed
the
gaolincheng/s3_aksk_use_secret
branch
2 times, most recently
from
7e1edaf to
508887d
Compare
LoveEachDay
reviewed
Oct 10, 2025
| port: "" | ||
| accessKey: "" | ||
| secretKey: "" | ||
| existingSecret: false |
Collaborator
There was a problem hiding this comment.
combine the values like this:
existingSecret:
enabled: false
name: s3-credentials
accessKey: "accessKey"
secretKey: "secretKey"
508887d to
08bc22e
Compare
LoveEachDay
reviewed
Oct 11, 2025
| $ helm upgrade --install my-release --set cluster.enabled=false --set standalone.messageQueue=kafka --set etcd.replicaCount=1 --set pulsarv3.enabled=false --set kafka.enabled=true --set minio.mode=standalone zilliztech/milvus | ||
| ``` | ||
| If you need to use standalone mode with embedded ETCD and local storage (without starting MinIO and additional ETCD), you can use the following steps: | ||
| use external S3 as object storage and store aksk in secret |
Collaborator
There was a problem hiding this comment.
Should put this into a separate section not under Deploy Milvus with standalone mode.
LoveEachDay
reviewed
Oct 11, 2025
| ``` | ||
| If you need to use standalone mode with embedded ETCD and local storage (without starting MinIO and additional ETCD), you can use the following steps: | ||
| use external S3 as object storage and store aksk in secret | ||
| 1. Create a secret with name `s3-credentials` in namespace `default` or use existing s3 aksk secret |
Collaborator
There was a problem hiding this comment.
No need to limit the namespace to default namespace.
doubledna
force-pushed
the
gaolincheng/s3_aksk_use_secret
branch
from
08bc22e to
2b49aa5
Compare
doubledna
force-pushed
the
gaolincheng/s3_aksk_use_secret
branch
from
2b49aa5 to
86923f0
Compare
Signed-off-by: doubledna <gaolin.cheng@zilliz.com>
doubledna
force-pushed
the
gaolincheng/s3_aksk_use_secret
branch
from
86923f0 to
dd725ca
Compare
|
bump! it's really needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: milvus connect external s3 aksk uses k8s secret storage. / s3 aksk stored in helm value is prone to leakage.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])