Conversation
Signed-off-by: haorenfsa <shaoyue.chen@zilliz.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haorenfsa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: haorenfsa <shaoyue.chen@zilliz.com>
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for Woodpecker as a new message queue option throughout the Milvus operator. Key changes include updating configuration files and CRDs to include Woodpecker, refactoring controller logic to handle the new type, and updating tests and generated code to reflect these modifications.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/min-mc-mixture.yaml, test/min-mc-feature.yaml | Update message stream type to Woodpecker |
| pkg/controllers/*.go | Update controller logic to support Woodpecker and refactor volume functions |
| deploy/manifests/deployment.yaml, config/crd/*, charts/milvus-operator/templates/crds.yaml | Update enumerations and schema definitions to include Woodpecker |
| apis/milvus.io/v1beta1/* | Update API types, deep copy functions, tests, and webhook logic to support Woodpecker |
| if len(builtInMq.Persistence.PersistentVolumeClaim.ExistingClaim) > 0 { | ||
| rocketMqPvcName = builtInMq.Persistence.PersistentVolumeClaim.ExistingClaim | ||
| } | ||
| userDefinedVolumes = append(userDefinedVolumes, persisentDataVolumeByName(rocketMqPvcName)) |
There was a problem hiding this comment.
[nitpick] The function name 'persisentDataVolumeByName' appears to be misspelled; consider renaming it to 'persistentDataVolumeByName' for improved clarity.
No description provided.