Skip to content

Update Go module location#309

Merged
sre-ci-robot merged 1 commit intozilliztech:mainfrom
SuperQ:superq/fix_mod
Apr 8, 2025
Merged

Update Go module location#309
sre-ci-robot merged 1 commit intozilliztech:mainfrom
SuperQ:superq/fix_mod

Conversation

@SuperQ
Copy link
Copy Markdown
Contributor

@SuperQ SuperQ commented Apr 7, 2025

The github.com/milvus-io/milvus-operator project was archived long ago in 2023. Update the Go module path to reflect the current home of the milvus-operator. This fixes Go importing of the project and links on pkg.go.dev.

@SuperQ
Copy link
Copy Markdown
Contributor Author

SuperQ commented Apr 7, 2025

For example, if you try and use https://pkg.go.dev/github.com/zilliztech/milvus-operator you currently get redirected to the obsolete milvus-io location.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.37%. Comparing base (080bd94) to head (cdaa904).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   75.37%   75.37%           
=======================================
  Files          64       64           
  Lines        6757     6757           
=======================================
  Hits         5093     5093           
  Misses       1462     1462           
  Partials      202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The `github.com/milvus-io/milvus-operator` project was archived long
ago in 2023. Update the Go module path to reflect the current home of
the milvus-operator. This fixes Go importing of the project and links
on `pkg.go.dev`.

Signed-off-by: SuperQ <superq@gmail.com>
@sre-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa, SuperQ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haorenfsa
Copy link
Copy Markdown
Collaborator

Wow, Thank you, @SuperQ!
By the way, I'm wondering how you did it. any tips to share?

@haorenfsa
Copy link
Copy Markdown
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm looks good to merge label Apr 8, 2025
@sre-ci-robot sre-ci-robot merged commit cfaf904 into zilliztech:main Apr 8, 2025
14 checks passed
@SuperQ
Copy link
Copy Markdown
Contributor Author

SuperQ commented Apr 8, 2025

You mean what script did I run?

ack -l 'github.com/zilliztech/milvus-operator' \
 | xargs sed -i -e 's|github.com/milvus-io/milvus-operator|github.com/zilliztech/milvus-operator|'

Plus a few manual edits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants