Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
==========================================
+ Coverage 75.37% 75.43% +0.05%
==========================================
Files 64 64
Lines 6757 6773 +16
==========================================
+ Hits 5093 5109 +16
Misses 1462 1462
Partials 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When internal etcd is in use, add the `client` port to the `PodMonitor` to collect metrics from the service pods. Fixes: zilliztech#310 Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/etcd_podmonitor
branch
from
8706ab4 to
c2c04d3
Compare
mergify
bot
added
do-not-merge/hold
ci-passed
and removed
ci-passed
do-not-merge/hold
labels
Contributor
Author
|
@haorenfsa How does this look with the check for both external etcd and internal with podmonitor enabled. |
Collaborator
|
/lgtm |
haorenfsa
approved these changes
Apr 15, 2025
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haorenfsa, SuperQ The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
Looks good! Thank you @SuperQ. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When internal etcd is in use, add the
clientport to thePodMonitorto collect metrics from the service pods.Fixes: #310