feat: Add Kafka credentials support via Kubernetes secrets#377
feat: Add Kafka credentials support via Kubernetes secrets#377Biowoolf wants to merge 4 commits intozilliztech:mainfrom
Conversation
|
Welcome @Biowoolf! It looks like this is your first PR to zilliztech/milvus-operator 🎉 |
ec7b588 to
2a3e0be
Compare
This commit adds support for external Kafka credentials through Kubernetes secrets, similar to how MinIO credentials are handled. Changes: - Add SecretRef field to MilvusKafka struct in dependencies_types.go - Add getKafkaCredentials function to retrieve username/password from secret - Update updateConfigMap to inject Kafka credentials when available - Add example configuration and documentation The operator now supports reading Kafka credentials from a secret with keys: - username: Kafka SASL username - password: Kafka SASL password This resolves the issue where Kafka credentials had to be hardcoded in the configuration, improving security by using Kubernetes secrets. Signed-off-by: Volkomorov Andrew <a.volkomorov@cyrm.ru> Signed-off-by: Volkomorov Andrew <biowoolf@bk.ru>
2a3e0be to
6cb3c8f
Compare
|
/assign @LoveEachDay |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
- Coverage 75.57% 75.39% -0.18%
==========================================
Files 65 65
Lines 7070 7088 +18
==========================================
+ Hits 5343 5344 +1
- Misses 1502 1518 +16
- Partials 225 226 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Biowoolf The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
what do i need to do for this PR to be merged? |
|
Thank you @Biowoolf. I'm sorry for the delay at my side. You need to run |
|
@Biowoolf Do you have any updates on the above pull request? Could you please run the |
This PR adds support for external Kafka credentials through Kubernetes secrets, improving security by avoiding hardcoded credentials in configuration files.
Changes:
Usage:
Users can now reference a Kubernetes secret containing Kafka credentials:
This follows the same pattern as MinIO credentials and is fully backward compatible.