Open
Conversation
… time Signed-off-by: tinswzy <zhenyuan.wei@zilliz.com>
Signed-off-by: tinswzy <zhenyuan.wei@zilliz.com>
Stop deleting checkpoint.blk during Finalize() so that future asynchronous tasks (e.g. index building, bloom filter generation) can read existing sections or append new ones to it. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Implement idempotent write capability to prevent duplicate log entries
when clients retry writes during network failures or timeouts.
Key components:
- IdempotentWriter: LogWriter wrapper with deduplication logic
- DedupWindow: Time and capacity bounded sliding window for tracking
committed idempotencyIds with Pending/Committed states
- DedupSnapshotManager: Persists dedup state to object storage for
crash recovery
Features:
- Auto-derive idempotencyId from payload MD5 if not provided
- Concurrent duplicate writes handled via sync.Cond
- Periodic snapshots with gap-based recovery
- Configurable window duration (default 5min) and capacity (default 1M)
Signed-off-by: tinswzy <zhenyuan.wei@zilliz.com>
tinswzy
force-pushed
the
dev
branch
4 times, most recently
from
c12c99a to
f295753
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #82