fix(#481): subtype relation for refined type members#581
Closed
zamadye wants to merge 1 commit intozio:developfrom
Closed
fix(#481): subtype relation for refined type members#581zamadye wants to merge 1 commit intozio:developfrom
zamadye wants to merge 1 commit intozio:developfrom
Conversation
Fix zio#481 - When comparing type members in refined types, the comparison was incorrectly checking for exact equality (lref == rref) instead of checking subtype relation (ctx.isChild). The fix changes the compareDecl function in LightTypeTagInheritance.scala to check subtype relation (ctx.isChild(lref, rref)) which is the correct semantics for comparing type members. Example: The fix resolves the issue where this was returning false. /claim zio#481
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #481\n\nFix #481 - When comparing type members in refined types (e.g., { type T = Int }), the comparison logic was checking for exact equality (ln == rn && lref == rref) instead of checking subtype relation.\n\nThe fix changes the condition to check subtype relation (ctx.isChild(lref, rref)) which is the correct semantics.\n\nThis resolves the issue where Tag[AInt].tag <:< Tag[A { type T = Int }].tag returns false when it should return true.