Refactor: Standardize constant naming to SCREAMING_SNAKE_CASE (#481)#583
Closed
yemsy26 wants to merge 1 commit intozio:developfrom
Closed
Refactor: Standardize constant naming to SCREAMING_SNAKE_CASE (#481)#583yemsy26 wants to merge 1 commit intozio:developfrom
yemsy26 wants to merge 1 commit intozio:developfrom
Conversation
Includes deprecated aliases for public and package-private API constants to preserve binary and source compatibility.
Author
|
I've recorded a short walkthrough showing the refactored constants, the deprecated aliases for binary compatibility, and the successful execution of the full test suite. Watch here: https://youtu.be/oCLTlZVTwB8 Everything is in green. Ready for review! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #481
Refactoring Constant Naming to SCREAMING_SNAKE_CASE
This PR standardizes the naming of all �al and inal val constants in object containers to follow the SCREAMING_SNAKE_CASE convention as per modern Scala standards.
Architectural Approach
Constants were identified and classified into three tiers to guarantee seamless backward compatibility:
(Note: Backtick properties in DebugProperties were excluded as they represent specific JVM system properties).
Macro Safety
Special care was taken for currentBinaryFormatVersion and LambdaConstants.tagMacro which are embedded by macros at compile-time. We updated the macro emitters (LightTypeTagMacro.scala, Inspect.scala, and TagMacro.scala) simultaneously to reference the new conventions explicitly. The @deprecated forwarders securely retain binary compatibility.
Verification