Skip to content

Expose output-file as an output when advanced-security: true#87

Merged
woodruffw merged 3 commits intozizmorcore:mainfrom
unlobito:output-for-sarif
Feb 1, 2026
Merged

Expose output-file as an output when advanced-security: true#87
woodruffw merged 3 commits intozizmorcore:mainfrom
unlobito:output-for-sarif

Conversation

@unlobito
Copy link
Copy Markdown
Contributor

Pre-submission checks

Please check these boxes:

  • Mandatory: This PR corresponds to an issue (if not, please create
    one first).

  • I hereby disclose the use of an LLM or other AI coding assistant in the
    creation of this PR. PRs will not be rejected for using AI tools, but
    will be rejected for undisclosed use.

If a checkbox is not applicable, you can leave it unchecked.

Summary

Fixes #86.

Expose the sarif-file output from action.sh as an output to the overall action called output-file

Test Plan

Tested on a private repo to ensure:

  • output-file is a filepath to the expected scan results in SARIF format
  • When advanced-security: false, the workflow still runs but output-file is an empty string

Co-authored-by: Lachlan Kidson <lachlan.kidson@skyscanner.net>
Copy link
Copy Markdown
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @unlobito, this looks good to me! Would you mind adding another self-test to the CI for this output? The other self-test jobs should be a decent reference, but LMK if you have any questions 🙂

@woodruffw woodruffw added the enhancement New feature or request label Jan 30, 2026
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw woodruffw merged commit fb94974 into zizmorcore:main Feb 1, 2026
15 checks passed
@woodruffw
Copy link
Copy Markdown
Member

Thanks @unlobito!

@unlobito
Copy link
Copy Markdown
Contributor Author

unlobito commented Feb 2, 2026

Hey @woodruffw, apologies for not getting this on Friday :( Was pulled in a few different directions and you got back to this before I had a chance to.

Maybe a bit awkward given the org-level template but, is it worth adding a note here / to the README about the self-tests? I admittedly completely missed https://github.com/zizmorcore/zizmor-action/blob/main/.github/workflows/selftest.yml during my draft.

No worries if you want to wait for some other changes, but I'd also really appreciate if you're able to publish this as a tagged release.

Thanks for your help with this PR, and thanks again for your work on zizmor! 🙇

@woodruffw
Copy link
Copy Markdown
Member

No worries at all @unlobito! Yeah, I think customizing the PR templates for this repo makes sense, and including a pointer to the self-tests would be ideal.

No worries if you want to wait for some other changes, but I'd also really appreciate if you're able to publish this as a tagged release.

Yeah, I will most likely do this sometime today. Please give me a ping in the next day or so if I don't, I don't mind being nudged on it.

@lachlankidson
Copy link
Copy Markdown
Contributor

@woodruffw just giving you that nudge you requested 🫣, thanks again for this!

@woodruffw
Copy link
Copy Markdown
Member

Thanks for the nudge, I've released 0.5.0 with this change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sarif-file isn't exposed as an output

3 participants