Merged
Conversation
Closes #633. Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Member
Author
|
This works, but comes with some significant limitations that make me hesitant to merge it: GitHub Actions currently limits check annotations to 10 per step, or 50 per job (if multiple steps are producing annotations). As a result, any In practice, I think this makes check annotations unworkable/unusable in the general case, since users have to dive into the action logs to see the findings that aren't given a check annotation due to the limit. More context here: https://github.com/orgs/community/discussions/26680, https://github.com/orgs/community/discussions/68471 |
2 tasks
Member
Author
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Member
Author
Signed-off-by: William Woodruff <william@yossarian.net>
aldur
pushed a commit
to aldur/zizmor
that referenced
this pull request
May 5, 2025
* cli: add a "GitHub" output format Closes zizmorcore#633. Signed-off-by: William Woodruff <william@yossarian.net> * try using SARIF path Signed-off-by: William Woodruff <william@yossarian.net> * fix lines Signed-off-by: William Woodruff <william@yossarian.net> * fmt Signed-off-by: William Woodruff <william@yossarian.net> * add --no-exit-codes Signed-off-by: William Woodruff <william@yossarian.net> * bump help snippet Signed-off-by: William Woodruff <william@yossarian.net> * bump snippet Signed-off-by: William Woodruff <william@yossarian.net> * integration test for github output Signed-off-by: William Woodruff <william@yossarian.net> * github: output tweaks * update snapshot * test-output: test GitHub output on just one file * remove columns * bump snapshot * try something else Signed-off-by: William Woodruff <william@yossarian.net> * fixup snapshot Signed-off-by: William Woodruff <william@yossarian.net> * one last hack Signed-off-by: William Woodruff <william@yossarian.net> * add primary annotation to message Signed-off-by: William Woodruff <william@yossarian.net> * usage: document --format=github, add integration docs Signed-off-by: William Woodruff <william@yossarian.net> * docs: update release notes --------- Signed-off-by: William Woodruff <william@yossarian.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Closes #633.