fix(rename-overwrite): handle EBUSY error code#216
Merged
zkochan merged 1 commit intozkochan:mainfrom May 16, 2025
anthochamp:fix-rename-overwrite-ebusy
Merged
fix(rename-overwrite): handle EBUSY error code#216zkochan merged 1 commit intozkochan:mainfrom anthochamp:fix-rename-overwrite-ebusy
zkochan merged 1 commit intozkochan:mainfrom
anthochamp:fix-rename-overwrite-ebusy
Conversation
|
@zkochan Thanks for accepting my @anthochamp's PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using rename-overwrite in Windows, EBUSY might be raised by the underlying OS which should trigger a retry the same way it is done for EACCESS/EPERM.
Context:
We're using pnpm on a large project and getting EBUSY error on CI (GitLab, Windows Server runners).
We traced back the problem to the call to
renameOverwritefrom the sync or async versions offorceSymlinkin the symlink-dir library.A similar issue has already been solved in pnpm.