fix(download): correctly parse remote URL#50
Merged
joelspadin merged 1 commit intozmkfirmware:mainfrom Jan 7, 2026
Merged
Conversation
This changes the "zmk download" command to use giturlparse when determining the URL for the GitHub actions page. This correctly handles URLs that end in ".git" as well as SSH "user@host:path" URLS.
caksoylar
approved these changes
Jan 7, 2026
Contributor
caksoylar
left a comment
caksoylar
left a comment
There was a problem hiding this comment.
Nice fix with giturlparse, so we don't have to hack around with string replacements for SSH remotes etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the "zmk download" command to use giturlparse when determining the URL for the GitHub actions page. This correctly handles URLs that end in ".git" as well as SSH "user@host:path" URLS.
Fixes #19, supersedes #20