feat: pass serial port request options during connection#27
Open
panzerstadt wants to merge 2 commits intozmkfirmware:mainfrom
Open
feat: pass serial port request options during connection#27panzerstadt wants to merge 2 commits intozmkfirmware:mainfrom
panzerstadt wants to merge 2 commits intozmkfirmware:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’d like to enhance the connect() function by allowing users to optionally pass in SerialPortRequestOptions.
This would enable us to specify VID/PID filters when initiating a connection, refining the list of available serial devices for selection.
By narrowing down the options, we can streamline the user experience, making it easier and more intuitive to choose the correct device (where possible)