feat(shields): Add dumbpad#1137
Closed
halcyonCorsair wants to merge 3 commits intozmkfirmware:mainfrom
Closed
Conversation
Nicell
added
enhancement
Nicell
requested changes
Apr 14, 2022
|
|
||
| # Uncomment to turn on logging, and set ZMK logging to debug output | ||
| # CONFIG_ZMK_USB_LOGGING=y | ||
| # CONFIG_SENSOR_LOG_LEVEL_DBG=y |
Member
There was a problem hiding this comment.
Just curious, what did you need this specific debug logging for?
Contributor
Author
There was a problem hiding this comment.
That was leftover from some debugging. I'll remove.
| @@ -0,0 +1,11 @@ | |||
| file_format: "1" | |||
Member
There was a problem hiding this comment.
Another one of these .zmk.ymls for the oled_top variant I think
Contributor
Author
|
@Nicell this is ready for review again when you have time. |
Nicell
reviewed
Jun 26, 2022
Comment on lines
+24
to
+29
| config LVGL_HOR_RES_MAX | ||
| default 128 | ||
|
|
||
| config LVGL_VER_RES_MAX | ||
| default 32 | ||
|
|
|
|
||
| # Uncomment to turn on logging, and set ZMK logging to debug output | ||
| # CONFIG_ZMK_USB_LOGGING=y | ||
| # CONFIG_SENSOR_LOG_LEVEL_DBG=y |
Member
There was a problem hiding this comment.
I think you mentioned you were going to remove this line, but I still see it 😄
Contributor
|
ZMK is currently not accepting any new shields for keyboards. Please make a module instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dumbpad macropad.
Board/Shield Check-list
.zmk.ymlmetadata file added&pro_microused in favor of&pro_micro_d/aif applicable.conffile has optional extra features commented out