ci: add reusable user-config workflow#1183
ci: add reusable user-config workflow#1183petejohanson merged 8 commits intozmkfirmware:mainfrom elagil:add_reusable_user_config_workflow
Conversation
elagil
changed the title
|
I added some input fields and tested my job again: https://github.com/elagil/ZMK-keyboards/actions/runs/2024498175 @joelspadin You may also test with your desired alternative inputs, using my branch like here. |
|
Some force-pushing for adhering to conventional commit messages. |
petejohanson
left a comment
petejohanson
left a comment
There was a problem hiding this comment.
Thanks! A few comments.
filterpaper
left a comment
filterpaper
left a comment
There was a problem hiding this comment.
This was discussed with @petejohanson on Discord—GH actions was reusing old caches from Zephyr 2.5 on 3.0 when the hash for user's west.yml remained unchanged. These proposed changes will trigger cache-misses with Zephyr version update.
Co-authored-by: Joel Spadin <joelspadin@gmail.com>
|
All suggestions were incorporated, please check if I missed something. |
petejohanson
left a comment
petejohanson
left a comment
There was a problem hiding this comment.
On a whole, looks god. Just one question/comment on the cache key.
Co-authored-by: Albert Y <76888457+filterpaper@users.noreply.github.com>
|
@petejohanson Do you have any further suggestions? |
petejohanson
left a comment
petejohanson
left a comment
There was a problem hiding this comment.
Ran wonderfully over at https://github.com/petejohanson/testing-3-0-update-zmk-config/runs/6069419685?check_suite_focus=true
No more concerns, this will definitely help us iterate on this, add enhancements like the work from @dxmh in zmkfirmware/unified-zmk-config-template#2 into one spot, and have it propagate to config repos automatically. Thanks!
4 participants
Closes #1178