added variations of breeze & default keymap#1312
added variations of breeze & default keymap#1312peterlvno wants to merge 3 commits intozmkfirmware:mainfrom
Conversation
👷 Deploy request for zmk pending review.Visit the deploys page to approve it
|
a633431 to
365b353
Compare
|
Hi @peterlvno, thanks for picking up the mantle of trying to get Breeze configs merged into ZMK. With the boards being open-sourced, I imagine there's going to be more interest in using ZMK with the Breeze boards. Your addition of the additional layouts (Southern Breeze, Summer Breeze, etc) is especially helpful. I can't tell if the failing checks for the last two commits are just for lack of a reviewer, or for some other reason, do you feel this PR is ready for re-review and merging? |
| // | ← | ↓ | → | SW24 | SW23 | SW22 | SW21 | SW20 | SW19 | | SW19 | SW20 | SW21 | SW22 | SW23 | SW24 | ← | ↓ | → | | ||
| // | TC4 | TC3 | TC2 | TC1 | | TC1 | TC2 | TC3 | TC4 | | ||
| map = < | ||
| RC(0,8) RC(0,7) RC(0,6) RC(0,5) RC(0,4) RC(0,3) RC(0,2) RC(0,1) RC(0,0) RC(5,0) RC(5,1) RC(5,2) RC(5,3) RC(5,4) RC(5,5) RC(5,3) RC(5,4) RC(5,5) RC(5,6) RC(5,7) RC(5,8) |
There was a problem hiding this comment.
There is maybe a copy/paste issue here, columns 3-5 are repeating on the right half.
There was a problem hiding this comment.
After rebasing on main, you'll definitely need to install and run pre-commit to deal with formatting issues (tabs, trailing whitespace, etc).
| RC(0,8) RC(0,7) RC(0,6) RC(0,5) RC(0,4) RC(0,3) RC(0,2) RC(0,1) RC(0,0) RC(5,0) RC(5,1) RC(5,2) RC(5,3) RC(5,4) RC(5,5) RC(5,3) RC(5,4) RC(5,5) RC(5,6) RC(5,7) RC(5,8) | ||
| RC(1,8) RC(1,7) RC(1,6) RC(1,5) RC(1,4) RC(1,3) RC(1,2) RC(1,1) RC(1,0) RC(6,0) RC(6,1) RC(6,2) RC(6,3) RC(6,4) RC(6,5) RC(6,3) RC(6,4) RC(6,5) RC(6,6) RC(6,7) RC(6,8) | ||
| RC(1,7) RC(2,5) RC(2,4) RC(2,3) RC(2,2) RC(2,1) RC(2,0) RC(7,0) RC(7,1) RC(7,2) RC(7,3) RC(7,4) RC(7,5) RC(7,3) RC(7,4) RC(7,5) RC(7,7) | ||
| RC(1,8) RC(1,7) RC(1,6) RC(3,5) RC(3,4) RC(3,3) RC(3,2) RC(3,1) RC(3,0) RC(8,0) RC(8,1) RC(8,2) RC(8,3) RC(8,4) RC(8,5) RC(8,3) RC(8,4) RC(8,5) RC(8,6) RC(8,7) RC(8,8) |
There was a problem hiding this comment.
I'm just going to assume caksoylar is right here and make a suggestion. Please confirm this on your hardware.
| RC(0,8) RC(0,7) RC(0,6) RC(0,5) RC(0,4) RC(0,3) RC(0,2) RC(0,1) RC(0,0) RC(5,0) RC(5,1) RC(5,2) RC(5,3) RC(5,4) RC(5,5) RC(5,3) RC(5,4) RC(5,5) RC(5,6) RC(5,7) RC(5,8) | |
| RC(1,8) RC(1,7) RC(1,6) RC(1,5) RC(1,4) RC(1,3) RC(1,2) RC(1,1) RC(1,0) RC(6,0) RC(6,1) RC(6,2) RC(6,3) RC(6,4) RC(6,5) RC(6,3) RC(6,4) RC(6,5) RC(6,6) RC(6,7) RC(6,8) | |
| RC(1,7) RC(2,5) RC(2,4) RC(2,3) RC(2,2) RC(2,1) RC(2,0) RC(7,0) RC(7,1) RC(7,2) RC(7,3) RC(7,4) RC(7,5) RC(7,3) RC(7,4) RC(7,5) RC(7,7) | |
| RC(1,8) RC(1,7) RC(1,6) RC(3,5) RC(3,4) RC(3,3) RC(3,2) RC(3,1) RC(3,0) RC(8,0) RC(8,1) RC(8,2) RC(8,3) RC(8,4) RC(8,5) RC(8,3) RC(8,4) RC(8,5) RC(8,6) RC(8,7) RC(8,8) | |
| RC(0,8) RC(0,7) RC(0,6) RC(0,5) RC(0,4) RC(0,3) RC(0,2) RC(0,1) RC(0,0) RC(5,0) RC(5,1) RC(5,2) RC(5,3) RC(5,4) RC(5,5) RC(5,6) RC(5,7) RC(5,8) | |
| RC(1,8) RC(1,7) RC(1,6) RC(1,5) RC(1,4) RC(1,3) RC(1,2) RC(1,1) RC(1,0) RC(6,0) RC(6,1) RC(6,2) RC(6,3) RC(6,4) RC(6,5) RC(6,6) RC(6,7) RC(6,8) | |
| RC(1,7) RC(2,5) RC(2,4) RC(2,3) RC(2,2) RC(2,1) RC(2,0) RC(7,0) RC(7,1) RC(7,2) RC(7,3) RC(7,4) RC(7,5) RC(7,7) | |
| RC(1,8) RC(1,7) RC(1,6) RC(3,5) RC(3,4) RC(3,3) RC(3,2) RC(3,1) RC(3,0) RC(8,0) RC(8,1) RC(8,2) RC(8,3) RC(8,4) RC(8,5) RC(8,6) RC(8,7) RC(8,8) |
|
|
||
| / { | ||
| keymap { | ||
| // Ref: https://zmkfirmware.dev/docs/codes/ |
There was a problem hiding this comment.
| // Ref: https://zmkfirmware.dev/docs/codes/ |
I'm inclined to think this isn't necessary.
| label = "KSCAN"; | ||
|
|
There was a problem hiding this comment.
| label = "KSCAN"; |
This attribute has been deprecated.
|
ZMK is currently not accepting any new shields for keyboards. Please make a module instead. |
Add a shield definition for the Breeze split keyboard from Afternoon labs.
This is for the standard breeze variant by default, with the arrow cluster present on the right half but not the left.
Additional layouts
The definition is based on a stagnant PR by @idan: #1125, which based on an abandoned PR by @devries: #735
Board/Shield Check-list
.zmk.ymlmetadata file added&pro_microused in favor of&pro_micro_d/aif applicable.conffile has optional extra features commented out