Skip to content

added variations of breeze & default keymap#1312

Closed
peterlvno wants to merge 3 commits intozmkfirmware:mainfrom
peterlvno:feat/breeze
Closed

added variations of breeze & default keymap#1312
peterlvno wants to merge 3 commits intozmkfirmware:mainfrom
peterlvno:feat/breeze

Conversation

@peterlvno
Copy link
Copy Markdown

Add a shield definition for the Breeze split keyboard from Afternoon labs.

This is for the standard breeze variant by default, with the arrow cluster present on the right half but not the left.
Additional layouts

The definition is based on a stagnant PR by @idan: #1125, which based on an abandoned PR by @devries: #735

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • Definitions follow the general style of other shields/boards upstream (Reference)
  • .zmk.yml metadata file added
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • &pro_micro used in favor of &pro_micro_d/a if applicable
  • If split, no name added for the right/peripheral half
  • Kconfig.defconfig file correctly wraps all configuration in conditional on the shield symbol
  • .conf file has optional extra features commented out
  • Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)

@netlify
Copy link
Copy Markdown

netlify bot commented May 19, 2022

👷 Deploy request for zmk pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 365b353

@peterlvno peterlvno force-pushed the feat/breeze branch 2 times, most recently from a633431 to 365b353 Compare May 26, 2022 06:45
@caksoylar caksoylar added the shields PRs and issues related to shields label Jul 4, 2022
@djsiroky
Copy link
Copy Markdown

djsiroky commented Jun 9, 2023

Hi @peterlvno, thanks for picking up the mantle of trying to get Breeze configs merged into ZMK. With the boards being open-sourced, I imagine there's going to be more interest in using ZMK with the Breeze boards. Your addition of the additional layouts (Southern Breeze, Summer Breeze, etc) is especially helpful.

I can't tell if the failing checks for the last two commits are just for lack of a reviewer, or for some other reason, do you feel this PR is ready for re-review and merging?

// | ← | ↓ | → | SW24 | SW23 | SW22 | SW21 | SW20 | SW19 | | SW19 | SW20 | SW21 | SW22 | SW23 | SW24 | ← | ↓ | → |
// | TC4 | TC3 | TC2 | TC1 | | TC1 | TC2 | TC3 | TC4 |
map = <
RC(0,8) RC(0,7) RC(0,6) RC(0,5) RC(0,4) RC(0,3) RC(0,2) RC(0,1) RC(0,0) RC(5,0) RC(5,1) RC(5,2) RC(5,3) RC(5,4) RC(5,5) RC(5,3) RC(5,4) RC(5,5) RC(5,6) RC(5,7) RC(5,8)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is maybe a copy/paste issue here, columns 3-5 are repeating on the right half.

@devries
Copy link
Copy Markdown

devries commented Jun 11, 2023

Tagging @devriesp who opened #735

Copy link
Copy Markdown
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After rebasing on main, you'll definitely need to install and run pre-commit to deal with formatting issues (tabs, trailing whitespace, etc).

Comment on lines +83 to +86
RC(0,8) RC(0,7) RC(0,6) RC(0,5) RC(0,4) RC(0,3) RC(0,2) RC(0,1) RC(0,0) RC(5,0) RC(5,1) RC(5,2) RC(5,3) RC(5,4) RC(5,5) RC(5,3) RC(5,4) RC(5,5) RC(5,6) RC(5,7) RC(5,8)
RC(1,8) RC(1,7) RC(1,6) RC(1,5) RC(1,4) RC(1,3) RC(1,2) RC(1,1) RC(1,0) RC(6,0) RC(6,1) RC(6,2) RC(6,3) RC(6,4) RC(6,5) RC(6,3) RC(6,4) RC(6,5) RC(6,6) RC(6,7) RC(6,8)
RC(1,7) RC(2,5) RC(2,4) RC(2,3) RC(2,2) RC(2,1) RC(2,0) RC(7,0) RC(7,1) RC(7,2) RC(7,3) RC(7,4) RC(7,5) RC(7,3) RC(7,4) RC(7,5) RC(7,7)
RC(1,8) RC(1,7) RC(1,6) RC(3,5) RC(3,4) RC(3,3) RC(3,2) RC(3,1) RC(3,0) RC(8,0) RC(8,1) RC(8,2) RC(8,3) RC(8,4) RC(8,5) RC(8,3) RC(8,4) RC(8,5) RC(8,6) RC(8,7) RC(8,8)
Copy link
Copy Markdown
Contributor

@lesshonor lesshonor Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just going to assume caksoylar is right here and make a suggestion. Please confirm this on your hardware.

Suggested change
RC(0,8) RC(0,7) RC(0,6) RC(0,5) RC(0,4) RC(0,3) RC(0,2) RC(0,1) RC(0,0) RC(5,0) RC(5,1) RC(5,2) RC(5,3) RC(5,4) RC(5,5) RC(5,3) RC(5,4) RC(5,5) RC(5,6) RC(5,7) RC(5,8)
RC(1,8) RC(1,7) RC(1,6) RC(1,5) RC(1,4) RC(1,3) RC(1,2) RC(1,1) RC(1,0) RC(6,0) RC(6,1) RC(6,2) RC(6,3) RC(6,4) RC(6,5) RC(6,3) RC(6,4) RC(6,5) RC(6,6) RC(6,7) RC(6,8)
RC(1,7) RC(2,5) RC(2,4) RC(2,3) RC(2,2) RC(2,1) RC(2,0) RC(7,0) RC(7,1) RC(7,2) RC(7,3) RC(7,4) RC(7,5) RC(7,3) RC(7,4) RC(7,5) RC(7,7)
RC(1,8) RC(1,7) RC(1,6) RC(3,5) RC(3,4) RC(3,3) RC(3,2) RC(3,1) RC(3,0) RC(8,0) RC(8,1) RC(8,2) RC(8,3) RC(8,4) RC(8,5) RC(8,3) RC(8,4) RC(8,5) RC(8,6) RC(8,7) RC(8,8)
RC(0,8) RC(0,7) RC(0,6) RC(0,5) RC(0,4) RC(0,3) RC(0,2) RC(0,1) RC(0,0) RC(5,0) RC(5,1) RC(5,2) RC(5,3) RC(5,4) RC(5,5) RC(5,6) RC(5,7) RC(5,8)
RC(1,8) RC(1,7) RC(1,6) RC(1,5) RC(1,4) RC(1,3) RC(1,2) RC(1,1) RC(1,0) RC(6,0) RC(6,1) RC(6,2) RC(6,3) RC(6,4) RC(6,5) RC(6,6) RC(6,7) RC(6,8)
RC(1,7) RC(2,5) RC(2,4) RC(2,3) RC(2,2) RC(2,1) RC(2,0) RC(7,0) RC(7,1) RC(7,2) RC(7,3) RC(7,4) RC(7,5) RC(7,7)
RC(1,8) RC(1,7) RC(1,6) RC(3,5) RC(3,4) RC(3,3) RC(3,2) RC(3,1) RC(3,0) RC(8,0) RC(8,1) RC(8,2) RC(8,3) RC(8,4) RC(8,5) RC(8,6) RC(8,7) RC(8,8)


/ {
keymap {
// Ref: https://zmkfirmware.dev/docs/codes/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Ref: https://zmkfirmware.dev/docs/codes/

I'm inclined to think this isn't necessary.

Comment on lines +93 to +94
label = "KSCAN";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label = "KSCAN";

This attribute has been deprecated.

@lesshonor lesshonor mentioned this pull request Jan 21, 2024
11 tasks
@nmunnich
Copy link
Copy Markdown
Contributor

nmunnich commented Mar 1, 2025

ZMK is currently not accepting any new shields for keyboards. Please make a module instead.

@nmunnich nmunnich closed this Mar 1, 2025
@peterlvno peterlvno deleted the feat/breeze branch March 5, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shields PRs and issues related to shields

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants