fix(boards): Suppress spurious devicetree warning for nRF5x boards#2318
Merged
petejohanson merged 2 commits intozmkfirmware:mainfrom Jun 30, 2024
Merged
fix(boards): Suppress spurious devicetree warning for nRF5x boards#2318petejohanson merged 2 commits intozmkfirmware:mainfrom
petejohanson merged 2 commits intozmkfirmware:mainfrom
Conversation
Contributor
Author
|
Looking at the results of the CI it seems that the pre_dt_board.cmake file needs to be placed here:https://github.com/zmkfirmware/zephyr/tree/v3.5.0%2Bzmk-fixes/boards/arm/seeeduino_xiao_ble for the seeduino xiao BLE |
nRF5x boards throw a spurious warning for duplicate unit-address when the devicetree gets processed Upstream issue: zephyrproject-rtos/zephyr#29713 Warning suppressed as per: https://docs.zephyrproject.org/latest/build/dts/intro-input-output.html Tested on a few nRF5x boards and i have no reason to think it would break things on the untested ones
ReFil
changed the title
petejohanson
approved these changes
Jun 30, 2024
Contributor
petejohanson
left a comment
petejohanson
left a comment
There was a problem hiding this comment.
Thanks!
Will need to fix the seeeduino XIAO BLE upstream and cherry pick in, to address that one. Good to fix these for now though to have good in tree reference boards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nRF5x boards throw a spurious warning for duplicate unit-address when the devicetree gets processed
Upstream issue: zephyrproject-rtos/zephyr#29713
Warning suppressed as per: https://docs.zephyrproject.org/latest/build/dts/intro-input-output.html
Tested on a few nRF5x boards and i have no reason to think it would break things on the untested ones