Adds support for the Ahokore V2#743
Adds support for the Ahokore V2#743dezlidezlidezli wants to merge 3 commits intozmkfirmware:mainfrom
Conversation
|
@dezlidezlidezli This message wasn't put here when the metadata changes came out. Please review these changes if you'd like to update and get this board merged in! Some parts may not be applicable to your board FYI. Thank you, contributor, for your patience with how long review and merge of boards/shields has taken! There are three recent refactors/changes to boards and shields that require some attention, and then we can finally get this PR merged!
Hardware MetadataThe ProblemWhen first developing the process around contributing new shields/boards to ZMK, we failed to recognize that several key files (setup scripts, documentation page of supported hardware, and GH Action The FixBy adding discrete metadata files that are located with the boards/shields in question, and using that metadata to generate setup scripts, website hardware list, etc., users can contributing new hardware descriptions without the need to change the same files that other contributors are changing. Next StepsFirst, refer to https://zmk.dev/docs/development/hardware-metadata-files to familiarize yourself with the new metadata file format. Next, you have two options for fixing up your PR:
Pro Micro shield DT naming changesIn #876, we have simplified the DT naming for the "nexus node" we expose for pro-micro compatible boards, deprecating the use of Please see https://zmk.dev/docs/development/new-shield#shield-overlays for the updated docs on this. Split Shield Advertising ChangesIn addition, if this is a split PR, please see #658 where we have changed our conventions to remove the the name from the right sides, to prevent users attempting to pair with them and causing split sync issues. This also includes removing the " Left" suffix from the naming on the left side. See the changes in that PR for examples of what to change with your split shield. Getting HelpIf you have any questions about any of these changes, please comment here and tag @zmkfirmware/boards-shields or ask in the |
|
This PR should probably be closed at this point. Anyone wishing to build Ahokore for ZMK should work with its zmk-config repository—or perhaps better, this module-ified fork. |
Hello all! This pull request adds support for the Ahokore V2, PCB files available in here. This is a wireless board (no shield) with designed with an nrf52840 holyiot module.
Please let me know if merging my code into main is the wrong thing to do at this point of ZMK's existence. I contacted Pete just before opening this, and he said merging into main would be a good idea for now.
The original Ahokore will not be produced at scale, and I do not see anyone else other than existing owners using it, so it will not be merged into main and the Ahokore V2 may take the name "ahokore".
To do before merged: