115 - Handle unsupported pixel formats properly#114
Open
bwsw wants to merge 8 commits intozmwangx:masterfrom
Open
115 - Handle unsupported pixel formats properly#114bwsw wants to merge 8 commits intozmwangx:masterfrom
bwsw wants to merge 8 commits intozmwangx:masterfrom
Conversation
bwsw
changed the title
Author
|
Related to #115 |
bwsw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As for now, if ffmpeg-sys package receives symbols that are not supported by
rust-ffmpegpackage, the build fail. I have met that situation when tried to build the package for Raspberry Pi withoutrpifeature (withrpifeature the build is also fails, it is another issue). Addingunimplemented!()match hand allows building the package properly. The library will fail in the runtime when the unsupported features are used.