Skip to content

DRAFT: verticalLabelDD for coordinate osurf#37

Merged
znicholls merged 1 commit intoznicholls:add-olsfrom
JamesAnstey:brand_osurf
Dec 18, 2025
Merged

DRAFT: verticalLabelDD for coordinate osurf#37
znicholls merged 1 commit intoznicholls:add-olsfrom
JamesAnstey:brand_osurf

Conversation

@JamesAnstey
Copy link
Copy Markdown
Contributor

Description

One-line change to add a verticalLabelDD for new coordinate osurf.

Used label ols based on @taylor13's suggestion here. oltop was also suggested - if this is preferable it's a easy change.

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Changelog item added to changelog/

@taylor13
Copy link
Copy Markdown

thanks, James. Any votes between "oltop" and "ols"? "ols" is shorter, but "oltop" is perhaps slightly more decipherable. For no reason whatsoever, I prefer "ols" but happy with either.

@znichollscr
Copy link
Copy Markdown
Contributor

@JamesAnstey I'm happy with either. Pick one then I'll merge and release this tomorrow my time

@znicholls
Copy link
Copy Markdown
Owner

Or, if you're lucky, @NiklasSchwind or @TessaM97 might be able to merge and release if you can get your decision in during euro time

@taylor13
Copy link
Copy Markdown

As I just noted om CMIP-Data-Request/Harmonised-Public-Consultation#112 (comment) , I guess we'll just go with "ols".

@JamesAnstey
Copy link
Copy Markdown
Contributor Author

As I just noted om CMIP-Data-Request/Harmonised-Public-Consultation#112 (comment) , I guess we'll just go with "ols".

Ok great - ols it is. Thanks in advance @znicholls @NiklasSchwind or @TessaM97 for merging!

@znicholls znicholls changed the base branch from main to add-ols December 18, 2025 20:59
@znicholls znicholls merged commit 01f7efa into znicholls:add-ols Dec 18, 2025
19 checks passed
@znicholls
Copy link
Copy Markdown
Owner

Released in https://github.com/znicholls/CMIP-branded-variable-mapper/releases/tag/v0.13.1

@JamesAnstey
Copy link
Copy Markdown
Contributor Author

Great - thanks very much @znicholls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants