Replace all uses of loadDocuments with HiddenBrowser and add artificial delay#15
Merged
dstillman merged 8 commits intozotero:masterfrom Apr 13, 2023
Merged
Conversation
The new HiddenBrowser is sometimes just a little too fast, so we need to slow it down artificially for detection to work in all cases where it worked before.
AbeJellinek
force-pushed
the
use-hidden-browser
branch
from
c3dfc00 to
649cfbf
Compare
Be nice if we could use Symbols instead of strings so they could be WeakMap keys and we wouldn't need dispose() at all, but those can't be structuredCloned across processes.
This fixes tests. Because remoteTranslate.js was loaded by zotero-service.js on each initialization, it would try to re-register its window actor between tests, which would cause an error and halt test execution. Better to do what HiddenBrowser.jsm does and make ourselves a module that only gets initialized once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs zotero/zotero#2784