Add function to map localized language names to ISO codes#16
Merged
dstillman merged 3 commits intozotero:masterfrom Mar 18, 2023
Merged
Add function to map localized language names to ISO codes#16dstillman merged 3 commits intozotero:masterfrom
dstillman merged 3 commits intozotero:masterfrom
Conversation
AbeJellinek
changed the title
itemToCSLJSON: Map localized language names to ISO codes
dstillman
added a commit
that referenced
this pull request
Mar 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We could extract the mapping generation to a build script and just load some JSON at runtime, but the procedure that builds it is fast - less than a hundredth of a second on my machine - and it only has to run once, so I wasn't sure it would be worth the added complexity.