This repository was archived by the owner on Nov 13, 2023. It is now read-only.
Fix failure to load schema when there is no profile of that type#916
Merged
Conversation
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
t1m0thyj
requested review from
ATorrise,
KevinLoesch1,
awharn,
gejohnston,
traeok and
zFernand0
Codecov ReportBase: 89.33% // Head: 89.34% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #916 +/- ##
=======================================
Coverage 89.33% 89.34%
=======================================
Files 206 206
Lines 11180 11187 +7
Branches 2488 2488
=======================================
+ Hits 9988 9995 +7
Misses 1192 1192
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
traeok
approved these changes
Dec 12, 2022
zFernand0
reviewed
Dec 12, 2022
zFernand0
left a comment
zFernand0
left a comment
Member
There was a problem hiding this comment.
The code changes LGTM!
However, I'm waiting for clarification on some of my comments/questions before I approve it
gejohnston
approved these changes
Dec 12, 2022
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
zFernand0
approved these changes
Dec 13, 2022
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
|
Kudos, SonarCloud Quality Gate passed! |
t1m0thyj
added
the
release-patch
|
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #645