fix(zosfiles): strip ANSI control character on FBA dataset download#2753
Open
Maanvi212006 wants to merge 1 commit into
Open
fix(zosfiles): strip ANSI control character on FBA dataset download#2753Maanvi212006 wants to merge 1 commit into
Maanvi212006 wants to merge 1 commit into
Conversation
Signed-off-by: Maanvi Chetwani <maanvichetwani21@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What It Does
Addresses the round-trip corruption issue described in #537, where downloading a member from an FBA (Fixed Block ANSI) dataset and re-uploading it without modification causes z/OSMF to add an extra ANSI control character to column 1 of every record. For datasets at max LRECL, this silently truncates the last character of the line and can cause
fwrite()errors on upload.This PR addresses approach # 1 from the issue discussion:
recfmis fetched viaList.dataSet(..., { attributes: true })(same pattern already used inCopy.isPDS).recfmstarts withFBA, the first character of each line is stripped from the downloaded file after the download completes.What this PR does NOT do yet
Note for reviewers
If the metadata lookup fails, it fail safe — skip the fix rather than break the download — which means the original bug can silently persist in that edge case
Related issue
Closes (partially) #537
How to Test
NA
Review Checklist
I certify that I have:
Additional Comments