Respect MAX_JSON_KEY size#618
Draft
Martin-Zeithaml wants to merge 3 commits into
Draft
Conversation
Signed-off-by: Martin Zeithaml <Martin.Zeithaml@broadcom.com>
Signed-off-by: Martin Zeithaml <Martin.Zeithaml@broadcom.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (n < 0 || (size_t)n >= sizeof(workStr)) { | ||
| break; | ||
| } | ||
| while (workStr[0] != '\0' && workStr[strlen(workStr)-1] != ']') { |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internally we have a limit
MAX_JSON_KEYis256.When deleting from JSON, working buffer is expecting
MAX_JSON_KEYlength, but this is not properly checked.Does not work & more issues found :-(
Seems the
keyis deleted forzowe.environments.deleteeeeeeeeeeeeeeeeeeeeeeee.....eeeeordeleteeeeeeeeeeeeeeeeeeeeeeee.....eeee!