Breaking changes introduced in deleteDataSet()

[JillieBeanSim]

Describe the bug

an optional parameter, options, was added to deleteDataSet ZE API. There is no check for existence of options before checking if options.volume == "VSAM" in the zosmf use of ZE APIs. We should check for options && options.volume string includes/matches to not cause errors to extenders that use the ZE API

To Reproduce

Expected behavior

Screenshots

Desktop (please complete the following information):

• OS:
• Zowe Explorer Version:
• (Optional) Zowe CLI Version:
• (Optional) Do you have secure credentials enabled?
• (Optional) Are you using a custom credential manager?

Additional context

[github-actions]

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

[phaumer]

It is a better idea to introduce new APIs and deprecate the old one instead of running the risk of breaking extenders. Should unit test catch these kind of regessions?

[zFernand0]

It is a better idea to introduce new APIs and deprecate the old one instead of running the risk of breaking extenders.

I don't disagree with introducing brand new optional APIs and deprecating the old ones. However, extenders are often not ready for that kind of change when it's time to remove those deprecated functions, and require the new APIs 😅

And in this instance, the signature of the function already included the options optional parameter, which might make deprecation unnecessary in this case 🙏

---

Should unit test catch these kind of regessions?

As far as unit test, this specific scenario is likely caught by static code-analysis tools rather than unit tests.

---

Another way we can catch these things is during the review process. 😢
I promise to do better myself 🙏

---

Related to:

• Delete VSAM datasets from Zowe Explorer View #3845