Skip to content

refactor: Use Mustache instead of Handlebars#2975

Merged
JillieBeanSim merged 3 commits into
nextfrom
chore/v3/mustache
Jun 25, 2024
Merged

refactor: Use Mustache instead of Handlebars#2975
JillieBeanSim merged 3 commits into
nextfrom
chore/v3/mustache

Conversation

@traeok

@traeok traeok commented Jun 24, 2024

Copy link
Copy Markdown
Member

Proposed changes

Uses the mustache dependency instead of handlebars to minimize dependency count.

Release Notes

Milestone: vNext

Changelog:
Removed handlebars dependency in favor of mustache for technical currency purposes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
@codecov

codecov Bot commented Jun 24, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.66%. Comparing base (253365c) to head (02e3a50).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2975      +/-   ##
==========================================
- Coverage   92.68%   92.66%   -0.02%     
==========================================
  Files         111      111              
  Lines       11017    11017              
  Branches     2343     2381      +38     
==========================================
- Hits        10211    10209       -2     
- Misses        804      806       +2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@traeok traeok marked this pull request as ready for review June 24, 2024 15:43
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>

@t1m0thyj t1m0thyj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @traeok!

@zFernand0 zFernand0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less transitive dependencies! 🥳
LGTM, thanks @traeok! 😋

@sonarqubecloud

Copy link
Copy Markdown

@JillieBeanSim JillieBeanSim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @traeok

@JillieBeanSim JillieBeanSim merged commit 52e5de7 into next Jun 25, 2024
@JillieBeanSim JillieBeanSim deleted the chore/v3/mustache branch June 25, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants