Allow extenders to show data set attributes#3730
Conversation
Signed-off-by: jace-roell <jace.roell@hotmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3730 +/- ##
=======================================
Coverage 93.62% 93.63%
=======================================
Files 124 126 +2
Lines 14114 14162 +48
Branches 3344 3325 -19
=======================================
+ Hits 13214 13260 +46
- Misses 898 900 +2
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
Signed-off-by: jace-roell <jace.roell@hotmail.com>
zFernand0
left a comment
zFernand0
left a comment
There was a problem hiding this comment.
LGTM! 😋
I know this is still in draft mode, but the functionality LGTM! 🥳
For awareness, the VSIX is 15Mb and this is how it looks when installed.
This is totally ok 🙏
|
📅 Suggested merge-by date: 7/14/2025 |
jace-roell
requested review from
JillieBeanSim,
awharn,
gejohnston,
pujal0909,
t1m0thyj,
traeok and
zFernand0
Signed-off-by: jace-roell <jace.roell@hotmail.com>
traeok
left a comment
traeok
left a comment
There was a problem hiding this comment.
Thanks for all your work on this Jace! This looks great and I'm sure extenders will be eager to make use of this 😋 I left a few requests, but the changes largely LGTM
traeok
left a comment
traeok
left a comment
There was a problem hiding this comment.
I left one more request to use a stricter type than any for the DatasetAttributesProvider.register function. The other comments are just suggestions.
| try { | ||
| attributes.push(...(await provider.fetchAttributes(context))); | ||
| } catch (e) { | ||
| Logger.getAppLogger().error(e); |
There was a problem hiding this comment.
Should we display the error as a warning or error notification if one of the providers failed? Otherwise, users might not notice that a provider failed to fetch attributes until they look at the log output.
Signed-off-by: jace-roell <jace.roell@hotmail.com>
jace-roell
dismissed stale reviews from t1m0thyj, anaxceron, and ATorrise
via
c4037e3
Signed-off-by: jace-roell <jace.roell@hotmail.com>
…er.ts Co-authored-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com> Signed-off-by: Jace Roell <111985297+jace-roell@users.noreply.github.com>
zFernand0
left a comment
zFernand0
left a comment
There was a problem hiding this comment.
LGTM! 😋
I'm not able to view the additional attributes with the new -1 version of the attribute-extender vsce, but I installed the old one, and it seems to work just fine 👍
|
Reminder: This pull request has a merge-by date coming up within the next 24 hours. Please review this PR as soon as possible. @gejohnston @JillieBeanSim @pujal0909 @awharn @traeok @ATorrise @t1m0thyj @anaxceron |
zFernand0
dismissed
traeok’s stale review
the error message is now being presented as a warning! 🙏
github-project-automation
Bot
moved this from Review/QA
to Closed
in Zowe Explorer for VS Code
9 participants
Updated VSIX: attribute-extender-0.0.1.vsix.zip
Proposed changes
DatasetAtrributeProvidersto provide additional attributes for data setsShow Attributeswebview to map keys to user-friendly display namesTesting:
attribute-extender-0.0.1-1.vsix in vscodeextender-show-attributesbranch on ZE and run the development hosta. Search data sets via zosmf
b. Right-click a data set and select
Show AttributesWIP: Releasing sample extender on
zowe-client-samplesrepoRelease Notes
Milestone:
Changelog:
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublishpnpm --filter vscode-extension-for-zowe vscode:prepublishCode coverage
Deployment
Further comments