Type hint: Add hints to TestMessageBox in ui_tools/test_messages.py#1613
Open
kushalnsetty wants to merge 2 commits intozulip:mainfrom
Open
Type hint: Add hints to TestMessageBox in ui_tools/test_messages.py#1613kushalnsetty wants to merge 2 commits intozulip:mainfrom
kushalnsetty wants to merge 2 commits intozulip:mainfrom
Conversation
4dc02b1 to
d62f542
Compare
Collaborator
Author
|
I've rebased the branch to include the issue reference #1337 in the commit messages as requested. Thanks for the guidance! |
d62f542 to
1b6dccd
Compare
Collaborator
Author
Collaborator
|
Please fix the failing tests. |
This adds type hints to all test functions in TestMessageBox. Fixes zulip#1337.
1b6dccd to
868e675
Compare
Collaborator
Author
|
@Niloth-p thankyou for your insights and my apology for replying so lately |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
This PR adds comprehensive type hints to the
TestMessageBoxclass and its associated helper functions withinzulipterminal/ui_tools/test_messages.py.As part of the effort to improve the project's type safety, this change:
@pytest.mark.parametrizedecorators.mocker,message_fixture, andwidget_size.mypyfor this file by removing the corresponding exclusion frompyproject.toml.External discussion & connections
test_messages.py#1337How did you test this?
mypy zulipterminal/ui_tools/messages.py.pytest zulipterminal/ui_tools/messages.py.Self-review checklist for each commit