tests: Add assertion for model.server_url in test_init#1618
tests: Add assertion for model.server_url in test_init#1618pushkarscripts wants to merge 1 commit intozulip:mainfrom
Conversation
5314751 to
b9b39bb
Compare
4df61fc to
afad74c
Compare
|
wait, quick addendum (I am "commit undisciplined" lol) but it may be a good idea to turn your two commits into one commit, since they're pretty much the same idea? (And, since I'd argue that it's only the second commit that truly resolved the The Zulip documentation discussing squashing commits in this manner, but perhaps not in enough detail to follow if you've never done an interactive rebase before... Totally unsure whether that describes you or not, but want to encourage you to ask for help if you need it! 🫡 |
Thanks for the suggestion. I’ll squash them into a single commit 👍 |
afad74c to
7edcf74
Compare
Add missing assertion for model.server_url in test_init, resolving the existing FIXME. Also extend coverage with a parametrized test covering multiple base_url scheme and netloc combinations.
7edcf74 to
6007acb
Compare
What does this PR do, and why?
Adds the missing assertion for
model.server_urlintest_init, resolving the existingFIXMEcomment.Also extends coverage with a parametrized test covering different
base_urlscheme andnetloccombinations to ensure correct normalization behavior.External discussion & connections
topicPR: Add test for model.server_url in test_initHow did you test this?
Self-review checklist for each commit